Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2030228: Fix StorageSpec resources field to use correct API #10630

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Bug 2030228: Fix StorageSpec resources field to use correct API #10630

merged 1 commit into from
Dec 9, 2021

Conversation

avivtur
Copy link
Contributor

@avivtur avivtur commented Dec 8, 2021 •
edited
Loading

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2030228

Analysis / Root cause:
dataVolumeTemplates.spec.storage.resources.requests was using V1ResourceRequirements instead of K8sIoApiCoreV1ResourceRequirements API which caused dataVolumeTemplates.spec.storage.resources.requests.storage to be unrecognized.

Solution Description:
when consuming K8sIoApiCoreV1ResourceRequirements by V1PersistentVolumeClaimSpec and V1beta1StorageSpec
we essure that dataVolumeTemplates.spec.storage.resources.requests.storage will exist
Signed-off-by: Aviv Turgeman aturgema@redhat.com

@avivtur
Bug 2030228: update DataVolume API
0c3fa93 
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2021

@avivtur: An error was encountered querying GitHub for users with public email (gouyang@redhat.com) for bug 2030228 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2030228: update DataVolume API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yaacov
Copy link
Member

yaacov commented Dec 8, 2021

/lgtm

@avivtur avivtur mentioned this pull request Dec 8, 2021
Merged
@openshift-ci openshift-ci bot added component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 8, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2021
@yaacov
Copy link
Member

yaacov commented Dec 8, 2021

/lgtm hold

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yaacov
Copy link
Member

yaacov commented Dec 8, 2021

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2021
@avivtur avivtur changed the title Bug 2030228: update DataVolume API Bug 2030228: Fix StorageSpec resources field to use correct API Dec 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2021

@avivtur: An error was encountered querying GitHub for users with public email (gouyang@redhat.com) for bug 2030228 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2030228: Fix StorageSpec resources field to use correct API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yaacov
Copy link
Member

yaacov commented Dec 8, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2021
@avivtur
Copy link
Contributor Author

avivtur commented Dec 8, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Dec 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2021

@avivtur: This pull request references Bugzilla bug 2030228, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 8, 2021
@openshift-ci openshift-ci bot requested a review from gouyang December 8, 2021 10:09
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7ef28d9 into openshift:master Dec 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2021

@avivtur: All pull requests linked via external trackers have merged:

Bugzilla bug 2030228 has been moved to the MODIFIED state.

In response to this:

Bug 2030228: Fix StorageSpec resources field to use correct API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glekner glekner Awaiting requested review from glekner

@mareklibra mareklibra Awaiting requested review from mareklibra

@gouyang gouyang Awaiting requested review from gouyang

Assignees

@yaacov yaacov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avivtur @yaacov @openshift-bot @openshift-merge-robot