Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Maintenance actions to bare metal node #3009

Merged
merged 1 commit into from Oct 26, 2019
Merged

Add Maintenance actions to bare metal node #3009

merged 1 commit into from Oct 26, 2019

Conversation

jtomasek
Copy link

@jtomasek jtomasek commented Oct 18, 2019 •
edited

Depends on #2969
Required by #3066

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. component/core Related to console core functionality component/metal3 Related to metal3-plugin component/shared Related to console-shared labels Oct 18, 2019
@jtomasek jtomasek mentioned this pull request Oct 23, 2019
Merged
@jtomasek jtomasek mentioned this pull request Oct 23, 2019
Merged
@knowncitizen
Copy link
Contributor

/test e2e-gcp-console

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 24, 2019
@honza
Copy link
Member

honza commented Oct 25, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2019
@knowncitizen
Copy link
Contributor

/lgtm

vojtechszocs
vojtechszocs reviewed Oct 25, 2019
View reviewed changes
frontend/packages/metal3-plugin/src/components/baremetal-nodes/menu-actions.ts
import { K8sKind, NodeKind, K8sResourceKind } from '@console/internal/module/k8s';
import { getName } from '@console/shared';
import { startNodeMaintenanceModal } from '../modals/StartNodeMaintenanceModal';
import stopNodeMaintenanceModal from '../modals/StopNodeMaintenanceModal';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: maybe improve consistency e.g. use named or default exports for all modal components 😃 can be done later.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops 😃, I'll fix this in subsequent PR.

@vojtechszocs
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza, jtomasek, knowncitizen, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jtomasek
Copy link
Author

/test e2e-gcp-console

@openshift-merge-robot openshift-merge-robot merged commit 360d8a8 into openshift:master Oct 26, 2019
@jtomasek jtomasek deleted the bmn-actions branch October 27, 2019 06:55
@spadgett spadgett added this to the v4.3 milestone Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtechszocs vojtechszocs vojtechszocs left review comments

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@knowncitizen knowncitizen Awaiting requested review from knowncitizen

Assignees

@knowncitizen knowncitizen

@honza honza

@vojtechszocs vojtechszocs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/metal3 Related to metal3-plugin component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jtomasek @knowncitizen @honza @vojtechszocs @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot