Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bare metal enhanced node detail page #3066

Merged
merged 2 commits into from
Nov 2, 2019
Merged

Add bare metal enhanced node detail page #3066

merged 2 commits into from
Nov 2, 2019

Conversation

jtomasek
Copy link

@jtomasek jtomasek commented Oct 23, 2019 •
edited
Loading

Depends on #3009
Required by #3067

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/metal3 Related to metal3-plugin size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 23, 2019
@jtomasek jtomasek mentioned this pull request Oct 23, 2019
Merged
@jtomasek jtomasek mentioned this pull request Oct 23, 2019
Merged
@jtomasek
Copy link
Author

/test e2e-aws-console-olm
/test e2e-gcp-console

@knowncitizen
Copy link
Contributor

/test e2e-gcp-console

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 24, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2019
@jtomasek
Copy link
Author

/test e2e-gcp-console

2 similar comments
@jtomasek
Copy link
Author

/test e2e-gcp-console

@jtomasek
Copy link
Author

/test e2e-gcp-console

@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@knowncitizen
Copy link
Contributor

/assign @vojtechszocs

vojtechszocs
vojtechszocs suggested changes Oct 31, 2019
View reviewed changes
frontend/integration-tests/tests/performance.scenario.ts
@@ -99,7 +99,8 @@ describe('Performance test', () => {

expect(routeChunk).not.toBeNull();
// FIXME: Really need to address this chunk size
if (routeName === 'catalog' || routeName === 'operator-hub') {
// TODO(jtomasek): extract common node components to @console/shared to reduce node chunk size
if (['catalog', 'operator-hub', 'node'].includes(routeName)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spadgett FYI

frontend/packages/metal3-plugin/src/components/baremetal-nodes/BareMetalNodeDetailsPage.tsx

const BareMetalNodeDetailsPage: React.FC<BareMetalNodeDetailsPageProps> = ({
hasNodeMaintenanceCapability,
...props
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: trailing , will probably trigger an ESLint warning.

frontend/packages/metal3-plugin/src/plugin.ts
type: 'Page/Route',
properties: {
exact: true,
path: ['/k8s/cluster/nodes/:name'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtomasek @spadgett FYI, for now the RoutePage extension doesn't support gating by feature flags, so this will always override ^^ route, assuming that Metal3 plugin is part of Console build.

@vojtechszocs
Copy link
Contributor

/lgtm

Not sure why Prettier / ESLint doesn't warn on missing trailing comma in BareMetalNodeDetailsPage.tsx, will take a look at that later.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 31, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@knowncitizen
Copy link
Contributor

/lgtm
/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza, jtomasek, knowncitizen, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett spadgett added this to the v4.3 milestone Nov 1, 2019
@vojtechszocs
Copy link
Contributor

Not sure why Prettier / ESLint doesn't warn on missing trailing comma in BareMetalNodeDetailsPage.tsx, will take a look at that later.

OK, I've completely missed the fact that trailing comma is disallowed (by spec) after the spread operator within a destructuring assignment. Sorry for the noise.

@jtomasek
Copy link
Author

jtomasek commented Nov 2, 2019

/retest

@jtomasek
Copy link
Author

jtomasek commented Nov 2, 2019

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 2, 2019 •
edited
Loading

@jtomasek: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm bba5ff3 link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 47c691a into openshift:master Nov 2, 2019
@jtomasek jtomasek deleted the bmn-detail-page branch November 3, 2019 19:50
@vojtechszocs vojtechszocs mentioned this pull request Nov 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtechszocs vojtechszocs vojtechszocs requested changes

@honza honza honza approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@knowncitizen knowncitizen Awaiting requested review from knowncitizen

Assignees

@knowncitizen knowncitizen

@vojtechszocs vojtechszocs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/metal3 Related to metal3-plugin lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.
8 participants
@jtomasek @knowncitizen @vojtechszocs @openshift-bot @openshift-ci-robot @honza @spadgett @openshift-merge-robot