Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1802600: Add unpause VM tests #4194

Merged
merged 1 commit into from Feb 27, 2020
Merged

Bug 1802600: Add unpause VM tests #4194

merged 1 commit into from Feb 27, 2020

Conversation

pcbailey
Copy link
Contributor

@pcbailey pcbailey commented Feb 5, 2020

This PR adds tests for the unpause VM functionality added in #3985.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/kubevirt Related to kubevirt-plugin labels Feb 5, 2020
@pcbailey pcbailey changed the title WIP: Add unpause VM tests Add unpause VM tests Feb 13, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2020
@pcbailey pcbailey changed the title Add unpause VM tests Bug 1802600: Add unpause VM tests Feb 13, 2020
@openshift-ci-robot
Copy link
Contributor

@pcbailey: This pull request references Bugzilla bug 1802600, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1802600: Add unpause VM tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 13, 2020
rhrazdil
rhrazdil suggested changes Feb 14, 2020
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/tests/vm.actions.scenario.ts
it(
'Unpauses VM',
async () => {
pauseVM(vmName, testName);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the pause action immediate? Shouldn't we wait for Paused status?

frontend/packages/kubevirt-plugin/integration-tests/views/editStatusView.ts
import { $, by } from 'protractor';

export const unpauseVMDialog = $(`[aria-label="Edit pause state"]`);
export const saveButton = unpauseVMDialog.element(by.buttonText('Unpause'));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better to call it unpauseButton?

frontend/packages/kubevirt-plugin/integration-tests/tests/vm.overview.scenario.ts
@@ -123,4 +123,12 @@ describe('Test VM overview', () => {
);
});
});

it('Check unpause VM when VM is running', async () => {
await vm.action(VM_ACTION.Start);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this deserves a docstring. I don't understand why opening a modal window unpauses the VM

@rhrazdil
Copy link

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@rhrazdil: This pull request references Bugzilla bug 1802600, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhrazdil
Copy link

Verified the tests, I'm okay with current implementation.
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 20, 2020
@spadgett spadgett added this to the v4.5 milestone Feb 20, 2020
@pcbailey
Copy link
Contributor Author

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@pcbailey: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pcbailey
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 21, 2020
@openshift-ci-robot
Copy link
Contributor

@pcbailey: This pull request references Bugzilla bug 1802600, which is valid.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

/hold
for test fix #4411

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2020
@spadgett
Copy link
Member

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2020
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 27, 2020
@rhrazdil
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, rhrazdil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 27, 2020 •
edited

@pcbailey: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify d221880 link /test verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 458ca23 into openshift:master Feb 27, 2020
@openshift-ci-robot
Copy link
Contributor

@pcbailey: All pull requests linked via external trackers have merged. Bugzilla bug 1802600 has been moved to the MODIFIED state.

In response to this:

Bug 1802600: Add unpause VM tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@pcbailey: #4194 failed to apply on top of branch "release-4.4":

Using index info to reconstruct a base tree...
M	frontend/packages/kubevirt-plugin/integration-tests/tests/models/kubevirtDetailView.ts
M	frontend/packages/kubevirt-plugin/integration-tests/tests/models/virtualMachine.ts
M	frontend/packages/kubevirt-plugin/integration-tests/tests/utils/consts.ts
M	frontend/packages/kubevirt-plugin/integration-tests/tests/utils/utils.ts
M	frontend/packages/kubevirt-plugin/integration-tests/tests/vm.overview.scenario.ts
M	frontend/packages/kubevirt-plugin/integration-tests/views/virtualMachine.view.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/views/virtualMachine.view.ts
CONFLICT (content): Merge conflict in frontend/packages/kubevirt-plugin/integration-tests/views/virtualMachine.view.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/vm.overview.scenario.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/utils/utils.ts
CONFLICT (content): Merge conflict in frontend/packages/kubevirt-plugin/integration-tests/tests/utils/utils.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/utils/consts.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/models/virtualMachine.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/models/kubevirtDetailView.ts
CONFLICT (content): Merge conflict in frontend/packages/kubevirt-plugin/integration-tests/tests/models/kubevirtDetailView.ts
error: Failed to merge in the changes.
Patch failed at 0001 Add unpause VM tests

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jelkosz
Copy link

jelkosz commented Feb 28, 2020

lets see if the cherry pick bot took the latest version:
/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@jelkosz: #4194 failed to apply on top of branch "release-4.4":

Using index info to reconstruct a base tree...
M	frontend/packages/kubevirt-plugin/integration-tests/tests/models/kubevirtDetailView.ts
M	frontend/packages/kubevirt-plugin/integration-tests/tests/models/virtualMachine.ts
M	frontend/packages/kubevirt-plugin/integration-tests/tests/utils/consts.ts
M	frontend/packages/kubevirt-plugin/integration-tests/tests/utils/utils.ts
M	frontend/packages/kubevirt-plugin/integration-tests/tests/vm.overview.scenario.ts
M	frontend/packages/kubevirt-plugin/integration-tests/views/virtualMachine.view.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/views/virtualMachine.view.ts
CONFLICT (content): Merge conflict in frontend/packages/kubevirt-plugin/integration-tests/views/virtualMachine.view.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/vm.overview.scenario.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/utils/utils.ts
CONFLICT (content): Merge conflict in frontend/packages/kubevirt-plugin/integration-tests/tests/utils/utils.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/utils/consts.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/models/virtualMachine.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/models/kubevirtDetailView.ts
CONFLICT (content): Merge conflict in frontend/packages/kubevirt-plugin/integration-tests/tests/models/kubevirtDetailView.ts
error: Failed to merge in the changes.
Patch failed at 0001 Add unpause VM tests

In response to this:

lets see if the cherry pick bot took the latest version:
/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jelkosz
Copy link

jelkosz commented Feb 28, 2020

it did :(
@pcbailey please backport manually

@pcbailey pcbailey mentioned this pull request Feb 28, 2020
Merged
@pcbailey pcbailey deleted the unpause-vm-tests branch October 26, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhrazdil rhrazdil rhrazdil requested changes

@jelkosz jelkosz Awaiting requested review from jelkosz

@rawagner rawagner Awaiting requested review from rawagner

Assignees

@rhrazdil rhrazdil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@pcbailey @openshift-ci-robot @rhrazdil @openshift-cherrypick-robot @openshift-bot @spadgett @jelkosz @openshift-merge-robot