Bug 1868653: Convert Pipeline StartedBy Label to Annotation

[andrewballantyne]

Fixes:
https://issues.redhat.com/browse/ODC-4862

Analysis / Root cause:
StartedBy was added in 4.5, it was added as a label. Labels have limitations, it was unclear the full usage of the name and it was incorrectly assigned to a label, whereas we need to support a full range of characters beyond what labels can have.

Solution Description:
Annotations do not have this limitation, moving the started by content from labels to annnotations.

Screen shots / Gifs for design review:

kube:admin

Email username:

Trigger:

Unit test coverage report:
No change

Test setup:

• Setup a Pipeline
• Start said Pipeline, notice the started by information that is your user
  • Try kube:admin
  • Try creating a user with an email address
• Setup a trigger and invoke it to see it still shows the trigger details

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@andrewballantyne: This pull request references Bugzilla bug 1868653, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1868653: Convert Pipeline StartedBy Label to Annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rottencandy]

If I create a PipelineRun using the cli, it's page crashes

[andrewballantyne]

If I create a PipelineRun using the cli, it's page crashes

Good catch, I did not try CLI and it makes sense that annotations are optional... thanks!

[rottencandy]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andrewballantyne]

/retest

[openshift-ci-robot]

@andrewballantyne: All pull requests linked via external trackers have merged:

• openshift/console#6639

Bugzilla bug 1868653 has been moved to the MODIFIED state.

In response to this:

Bug 1868653: Convert Pipeline StartedBy Label to Annotation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andrewballantyne]

/cherry-pick release-4.5

[openshift-cherrypick-robot]

@andrewballantyne: #6639 failed to apply on top of branch "release-4.5":

Applying: Convert Pipeline StartedBy Label to Annotation
Using index info to reconstruct a base tree...
M	frontend/packages/dev-console/src/components/pipelineruns/PipelineRunDetailsPage.tsx
M	frontend/packages/dev-console/src/components/pipelineruns/triggered-by/hooks.ts
M	frontend/packages/dev-console/src/components/pipelines/PipelineDetailsPage.tsx
M	frontend/packages/dev-console/src/components/pipelines/modals/common/__tests__/utils.spec.ts
M	frontend/packages/dev-console/src/components/pipelines/modals/common/utils.ts
M	frontend/packages/dev-console/src/components/pipelines/modals/start-pipeline/StartPipelineModal.tsx
M	frontend/packages/dev-console/src/components/pipelines/modals/triggers/submit-utils.ts
M	frontend/packages/dev-console/src/utils/pipeline-actions.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/dev-console/src/utils/pipeline-actions.tsx
Auto-merging frontend/packages/dev-console/src/components/pipelines/modals/triggers/submit-utils.ts
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/components/pipelines/modals/triggers/submit-utils.ts
Auto-merging frontend/packages/dev-console/src/components/pipelines/modals/start-pipeline/StartPipelineModal.tsx
Auto-merging frontend/packages/dev-console/src/components/pipelines/modals/common/utils.ts
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/components/pipelines/modals/common/utils.ts
Auto-merging frontend/packages/dev-console/src/components/pipelines/modals/common/__tests__/utils.spec.ts
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/components/pipelines/modals/common/__tests__/utils.spec.ts
Auto-merging frontend/packages/dev-console/src/components/pipelines/PipelineDetailsPage.tsx
Auto-merging frontend/packages/dev-console/src/components/pipelineruns/triggered-by/hooks.ts
Auto-merging frontend/packages/dev-console/src/components/pipelineruns/PipelineRunDetailsPage.tsx
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/components/pipelineruns/PipelineRunDetailsPage.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Convert Pipeline StartedBy Label to Annotation
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andrewballantyne]

Cherry Pick will have to be done manually with the addition of this change: #6744 for 4.5