Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1882529: Removes the kubectl annotation from the created PLRs #6744

Merged

Conversation

andrewballantyne
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/ODC-4917

Analysis / Root cause:
Blindly copying all the annotations over seems to cause an issue with the TriggerTemplate creation if there is an issue in the kubectl.kubernetes.io/last-applied-configuration annotation

[Temp] Solution Description:
Remove the annotation as it's a hold over from the previous configuration.

There is a growing need to refactor this method and subsequently the callers to properly define a clean structure... however this shouldn't be done in 4.6 and definitely not this close to Code Freeze.

Screen shots / Gifs for design review:
No visual change.

Test setup:
See the ticket.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 24, 2020
@andrewballantyne andrewballantyne changed the title Removes the kubectl annotation from the created PLRs Bug 1882529: Removes the kubectl annotation from the created PLRs Sep 24, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 24, 2020
@openshift-ci-robot
Copy link
Contributor

@andrewballantyne: This pull request references Bugzilla bug 1882529, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1882529: Removes the kubectl annotation from the created PLRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 24, 2020
@andrewballantyne
Copy link
Contributor Author

Cherry-pick to 4.5 should be done manually with #6639

Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally, works fine with the given resources.yaml.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2f74e8e into openshift:master Sep 25, 2020
@openshift-ci-robot
Copy link
Contributor

@andrewballantyne: All pull requests linked via external trackers have merged:

Bugzilla bug 1882529 has been moved to the MODIFIED state.

In response to this:

Bug 1882529: Removes the kubectl annotation from the created PLRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants