New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1882529: Removes the kubectl annotation from the created PLRs #6744
Bug 1882529: Removes the kubectl annotation from the created PLRs #6744
Conversation
@andrewballantyne: This pull request references Bugzilla bug 1882529, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cherry-pick to 4.5 should be done manually with #6639 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally, works fine with the given resources.yaml.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, jerolimov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@andrewballantyne: All pull requests linked via external trackers have merged: Bugzilla bug 1882529 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-4917
Analysis / Root cause:
Blindly copying all the annotations over seems to cause an issue with the TriggerTemplate creation if there is an issue in the
kubectl.kubernetes.io/last-applied-configuration
annotation[Temp] Solution Description:
Remove the annotation as it's a hold over from the previous configuration.
There is a growing need to refactor this method and subsequently the callers to properly define a clean structure... however this shouldn't be done in 4.6 and definitely not this close to Code Freeze.
Screen shots / Gifs for design review:
No visual change.
Test setup:
See the ticket.
Browser conformance: