Bug 1766287: - "hello-openshift" template application wrong binary format #7186

cyril-ui-developer · 2020-11-11T16:58:26Z

Changed the image to registry.redhat.io/openshift4/ose-hello-openshift-rhel8 but I'm getting ImagePullBackOff error for pods

openshift-ci-robot · 2020-11-11T16:58:35Z

@cyril-ui-developer: This pull request references Bugzilla bug 1766287, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

[WIP] Bug 1766287: - "hello-openshift" template application wrong binary format

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-11-11T16:58:56Z

@cyril-ui-developer: This pull request references Bugzilla bug 1766287, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

[WIP] Bug 1766287: - "hello-openshift" template application wrong binary format

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett · 2020-11-11T17:15:11Z

frontend/public/models/yaml-templates.ts

@@ -229,6 +233,8 @@ apiVersion: apps/v1
 kind: Deployment
 metadata:
  name: example
+  annotations:
+    image.openshift.io/triggers: ${sampleContainerImage}


If we're using image.openshift.io/triggers, we should refer to the image stream. This should look like

Suggested change

image.openshift.io/triggers: ${sampleContainerImage}

image.openshift.io/triggers: |-

[

{

"from": {

"kind": "ImageStreamTag",

"name": "openshift/hello-openshift:latest"

},

"fieldPath": "spec.template.spec.containers[0].image"

}

]

@spadgett Updated, thanks.

spadgett · 2020-11-13T17:09:34Z

frontend/public/models/yaml-templates.ts

@@ -403,14 +431,26 @@ apiVersion: v1
 kind: Pod
 metadata:
  name: example
+  annotations:
+    image.openshift.io/triggers: |-


I don't think this will work for an individual pod since image is immutable after the pod is created.

spadgett · 2020-11-13T17:11:29Z

frontend/public/models/yaml-templates.ts

@@ -338,6 +354,17 @@ apiVersion: apps.openshift.io/v1
 kind: DeploymentConfig
 metadata:
  name: example
+  annotations:
+    image.openshift.io/triggers: |-


DeploymentConfigs have first class API support for triggers and don't need to use the annotation.

$ oc explain deploymentconfig.spec.triggers KIND: DeploymentConfig VERSION: apps.openshift.io/v1 RESOURCE: triggers <[]Object> DESCRIPTION: Triggers determine how updates to a DeploymentConfig result in new deployments. If no triggers are defined, a new deployment can only occur as a result of an explicit client update to the DeploymentConfig with a new LatestVersion. If null, defaults to having a config change trigger. DeploymentTriggerPolicy describes a policy for a single trigger that results in a new deployment. FIELDS: imageChangeParams <Object> ImageChangeParams represents the parameters for the ImageChange trigger. type <string> Type of the trigger

@spadgett Removed the trigger for Pod and DeploymentConfigs.
Do we need to revert the image to openshift/hello-openshift for Pod and DeploymentConfigs?

@cyril-ui-developer You shouldn't remove the trigger for DeploymentConfigs. Instead update it to use the spec.triggers instead of the annotation.

I'd just use registry.redhat.io/openshift4/ose-hello-openshift-rhel8 directly for pods.

@spadgett Updated, thanks! However the status is still ImagePullBackOff instead of Running.

spadgett

/lgtm

openshift-ci-robot · 2020-11-24T18:47:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-11-24T21:10:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-24T21:22:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-24T23:06:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-24T23:32:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-25T00:11:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot · 2020-11-25T07:29:50Z

@cyril-ui-developer: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-console	`eee9a0c`	link	`/test e2e-gcp-console`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-11-25T07:34:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-11-25T07:36:43Z

@cyril-ui-developer: All pull requests linked via external trackers have merged:

Bugzilla bug 1766287 has been moved to the MODIFIED state.

In response to this:

Bug 1766287: - "hello-openshift" template application wrong binary format

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot assigned cyril-ui-developer Nov 11, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2020

openshift-ci-robot requested review from jeff-phillips-18 and zherman0 November 11, 2020 16:58

cyril-ui-developer force-pushed the template-app-wrong-binary-format branch from 831b09d to 1d87f84 Compare November 11, 2020 17:13

spadgett reviewed Nov 11, 2020

View reviewed changes

cyril-ui-developer force-pushed the template-app-wrong-binary-format branch from 1d87f84 to 44750c0 Compare November 11, 2020 21:05

spadgett reviewed Nov 13, 2020

View reviewed changes

cyril-ui-developer force-pushed the template-app-wrong-binary-format branch 2 times, most recently from c30f13b to c7ab555 Compare November 16, 2020 19:15

template application wrong binary format

eee9a0c

cyril-ui-developer force-pushed the template-app-wrong-binary-format branch from c7ab555 to eee9a0c Compare November 24, 2020 18:29

cyril-ui-developer changed the title ~~[WIP] Bug 1766287: - "hello-openshift" template application wrong binary format~~ Bug 1766287: - "hello-openshift" template application wrong binary format Nov 24, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2020

spadgett approved these changes Nov 24, 2020

View reviewed changes

openshift-ci-robot assigned spadgett Nov 24, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2020

openshift-merge-robot merged commit 14c6751 into openshift:master Nov 25, 2020

spadgett added this to the v4.7 milestone Nov 30, 2020

spadgett mentioned this pull request Dec 11, 2020

Bug 1905128: Fix prow's e2e test script #7446

Merged

openshift-ci-robot mentioned this pull request Dec 23, 2020

Bug 1766287: Improve usability of hello-openshift imagestream openshift/cluster-samples-operator#350

Merged

openshift-ci-robot mentioned this pull request Jan 6, 2021

Bug 1766287: Fix use of hello-openshift imagestream #7646

Merged

openshift-ci-robot mentioned this pull request Mar 26, 2021

Bug 1766287: Use httpd in workload YAML templates #8459

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1766287: - "hello-openshift" template application wrong binary format #7186

Bug 1766287: - "hello-openshift" template application wrong binary format #7186

cyril-ui-developer commented Nov 11, 2020 •

edited

openshift-ci-robot commented Nov 11, 2020

openshift-ci-robot commented Nov 11, 2020

spadgett Nov 11, 2020

cyril-ui-developer Nov 13, 2020

spadgett Nov 13, 2020

spadgett Nov 13, 2020

cyril-ui-developer Nov 16, 2020

spadgett Nov 16, 2020

cyril-ui-developer Nov 16, 2020

spadgett left a comment

openshift-ci-robot commented Nov 24, 2020

openshift-bot commented Nov 24, 2020

openshift-bot commented Nov 24, 2020

openshift-bot commented Nov 24, 2020

openshift-bot commented Nov 24, 2020

openshift-bot commented Nov 25, 2020

openshift-merge-robot commented Nov 25, 2020

openshift-bot commented Nov 25, 2020

openshift-ci-robot commented Nov 25, 2020

-    image.openshift.io/triggers: ${sampleContainerImage}
+    image.openshift.io/triggers: |-
+      [
+        {
+          "from": {
+            "kind": "ImageStreamTag",
+            "name": "openshift/hello-openshift:latest"
+          },
+          "fieldPath": "spec.template.spec.containers[0].image"
+        }
+      ]

Bug 1766287: - "hello-openshift" template application wrong binary format #7186

Bug 1766287: - "hello-openshift" template application wrong binary format #7186

Conversation

cyril-ui-developer commented Nov 11, 2020 • edited

openshift-ci-robot commented Nov 11, 2020

openshift-ci-robot commented Nov 11, 2020

spadgett Nov 11, 2020

Choose a reason for hiding this comment

cyril-ui-developer Nov 13, 2020

Choose a reason for hiding this comment

spadgett Nov 13, 2020

Choose a reason for hiding this comment

spadgett Nov 13, 2020

Choose a reason for hiding this comment

cyril-ui-developer Nov 16, 2020

Choose a reason for hiding this comment

spadgett Nov 16, 2020

Choose a reason for hiding this comment

cyril-ui-developer Nov 16, 2020

Choose a reason for hiding this comment

spadgett left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Nov 24, 2020

openshift-bot commented Nov 24, 2020

openshift-bot commented Nov 24, 2020

openshift-bot commented Nov 24, 2020

openshift-bot commented Nov 24, 2020

openshift-bot commented Nov 25, 2020

openshift-merge-robot commented Nov 25, 2020

openshift-bot commented Nov 25, 2020

openshift-ci-robot commented Nov 25, 2020

cyril-ui-developer commented Nov 11, 2020 •

edited