Bug 1766287: Improve usability of hello-openshift imagestream #350

yselkowitz · 2020-12-22T21:14:45Z

Set local lookup policy on CVO manifests
Update hello-openshift pullspec in CVO manifests

openshift-ci-robot · 2020-12-22T21:29:53Z

@yselkowitz: This pull request references Bugzilla bug 1766287, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1766287: Improve usability of CVO manifests imagestreams

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yselkowitz · 2020-12-22T23:31:34Z

/retest

yselkowitz · 2020-12-23T01:35:56Z

/retest

yselkowitz · 2020-12-23T06:41:11Z

/retest

adambkaplan

/hold

@yselkowitz over Slack you asked, "Why don't we set lookupPolicy: local: true on everything?", and at the time I didn't have a good reason not to.

Now that the PR is in front of me, I have found a reason why we haven't set this field. Our convention for imagestream tag pull specs can overlap with actual Docker Hub images. In the case of oath-proxy and hello-openshift we would replace the docker hub image with the one from the payload on upgrade. To me, this is a breaking change.

Unfortunately this means that @cyril-ui-developer is out of luck here. His next best option is to add the alpha.image.policy.openshift.io/resolve-names: '*' annotation to the Deployment's pod template spec.

See https://docs.openshift.com/container-platform/4.6/openshift_images/using-imagestreams-with-kube-resources.html#images-managing-images-enabling-imagestreams-kube_using-imagestreams-with-kube-resources

adambkaplan · 2020-12-23T13:41:01Z

manifests/08-openshift-imagestreams.yaml

+  lookupPolicy:
+    local: true


openshift/oauth-proxy resolves to a Docker Hub image. There is a risk that an end-user is pulling the (obsolete) oauth-proxy image from Docker Hub today, and with this switch will start pulling the image from the internal registry.

https://hub.docker.com/r/openshift/oauth-proxy

That probably would be a good thing, but let's leave that for further discussion in a separate PR.

adambkaplan · 2020-12-23T13:43:27Z

manifests/08-openshift-imagestreams.yaml

+  lookupPolicy:
+    local: true


Likewise, openshift/hello-openshift resolves to a Docker Hub image.

That is actually the entire point of the (new in 4.7) hello-openshift imagestream, to easily replace uses of the unmaintained, single-arch, and now rate-limited image on docker.io.

yselkowitz · 2020-12-23T15:49:20Z

Repushed the PR limiting the changes to hello-openshift for now.

adambkaplan

/hold cancel

/approve

adambkaplan · 2020-12-23T16:13:18Z

@yselkowitz please squash your commits.

This is necessary to allow a Deployment to use it with little to no change: https://austindewey.com/2020/10/25/you-can-use-openshifts-imagestreams-with-deployments-heres-how/ Also, update hello-openshift pullspec in CVO manifests to point to the OKD builds on quay.io like the others.

yselkowitz · 2020-12-23T16:17:44Z

Squashed as requested.

adambkaplan

/lgtm

Tested via cluster-bot and the dev console. Image replacement still works when the alpha.image.policy.openshift.io/resolve-names: '*' annotation is removed.

openshift-ci-robot · 2020-12-23T17:56:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-12-23T19:40:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-12-23T21:25:29Z

@yselkowitz: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/console#7646 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1766287 has not been moved to the MODIFIED state.

In response to this:

Bug 1766287: Improve usability of hello-openshift imagestream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

smarterclayton · 2021-01-07T03:18:32Z

I asked for this image to be removed from the product in openshift/enhancements#438 - I really don't want to be adding stuff around this. Ingress should be using their operator image and a subcommand of their operator binary, not depending on a generic example image.

gabemontero · 2021-01-07T14:49:42Z

I asked for this image to be removed from the product in openshift/enhancements#438 - I really don't want to be adding stuff around this. Ingress should be using their operator image and a subcommand of their operator binary, not depending on a generic example image.

OK @smarterclayton I've subscribed to that EP (I see @yselkowitz already responded to you there on current usage of this imagestream) and ack that I'm now officially aware of your wishes

My first thought is that I need to invesitigate / understand when the existing multi arch / console / serverless uses will be replaced so as not to break them. Or do you want this imagestream removed now as a way to trigger their replacement?

openshift-ci-robot assigned adambkaplan Dec 22, 2020

openshift-ci-robot requested review from adambkaplan and gabemontero December 22, 2020 21:15

yselkowitz changed the title ~~Improve usability of CVO manifests imagestreams~~ Bug 1766287: Improve usability of CVO manifests imagestreams Dec 22, 2020

openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Dec 22, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 22, 2020

adambkaplan reviewed Dec 23, 2020

View reviewed changes

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2020

yselkowitz force-pushed the master branch from ad64b58 to 0e41332 Compare December 23, 2020 15:46

yselkowitz changed the title ~~Bug 1766287: Improve usability of CVO manifests imagestreams~~ Bug 1766287: Improve usability of hello-openshift imagestream Dec 23, 2020

yselkowitz mentioned this pull request Dec 23, 2020

Bug 1766287: Fix use of hello-openshift imagestream openshift/console#7646

Merged

adambkaplan approved these changes Dec 23, 2020

View reviewed changes

openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 23, 2020

yselkowitz force-pushed the master branch from 0e41332 to 04ff0d4 Compare December 23, 2020 16:16

adambkaplan approved these changes Dec 23, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2020

openshift-merge-robot merged commit aa144e2 into openshift:master Dec 23, 2020

openshift-ci-robot mentioned this pull request Mar 26, 2021

Bug 1766287: Use httpd in workload YAML templates openshift/console#8459

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1766287: Improve usability of hello-openshift imagestream #350

Bug 1766287: Improve usability of hello-openshift imagestream #350

yselkowitz commented Dec 22, 2020

openshift-ci-robot commented Dec 22, 2020

yselkowitz commented Dec 22, 2020

yselkowitz commented Dec 23, 2020

yselkowitz commented Dec 23, 2020

adambkaplan left a comment •

edited

adambkaplan Dec 23, 2020

yselkowitz Dec 23, 2020

adambkaplan Dec 23, 2020

yselkowitz Dec 23, 2020

yselkowitz commented Dec 23, 2020

adambkaplan left a comment

adambkaplan commented Dec 23, 2020

yselkowitz commented Dec 23, 2020

adambkaplan left a comment

openshift-ci-robot commented Dec 23, 2020

openshift-bot commented Dec 23, 2020

openshift-ci-robot commented Dec 23, 2020

smarterclayton commented Jan 7, 2021

gabemontero commented Jan 7, 2021

Bug 1766287: Improve usability of hello-openshift imagestream #350

Bug 1766287: Improve usability of hello-openshift imagestream #350

Conversation

yselkowitz commented Dec 22, 2020

openshift-ci-robot commented Dec 22, 2020

yselkowitz commented Dec 22, 2020

yselkowitz commented Dec 23, 2020

yselkowitz commented Dec 23, 2020

adambkaplan left a comment • edited

Choose a reason for hiding this comment

adambkaplan Dec 23, 2020

Choose a reason for hiding this comment

yselkowitz Dec 23, 2020

Choose a reason for hiding this comment

adambkaplan Dec 23, 2020

Choose a reason for hiding this comment

yselkowitz Dec 23, 2020

Choose a reason for hiding this comment

yselkowitz commented Dec 23, 2020

adambkaplan left a comment

Choose a reason for hiding this comment

adambkaplan commented Dec 23, 2020

yselkowitz commented Dec 23, 2020

adambkaplan left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Dec 23, 2020

openshift-bot commented Dec 23, 2020

openshift-ci-robot commented Dec 23, 2020

smarterclayton commented Jan 7, 2021

gabemontero commented Jan 7, 2021

adambkaplan left a comment •

edited