[release-4.6] Bug 1933727: fix Internal registry deploy flow

[karthikjeeyar]

This is a manual cherry pick of #7727

Note: Removed Translation related content as we do not have translations handled on 4.6

Fixes:

https://issues.redhat.com/browse/ODC-5259

Analysis / Root cause:

Users with edit right are unable to deploy images from their own namespace in the UI but they can do it using the CLI.
Solution Description:

Reverting back to 3.11 like flow for avoiding the permission issue caused while granting access via UI

Screen shots / Gifs for design review:

1. User chooses the same project
   

2. User chooses a different project
   

Unit test coverage report:

Test setup:

1. Create a user with edit right to a namespace
2. go to the namespace and use internal image registry option
3. now choose an image stream from the user's own namespace for creation.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

cc: @invincibleJai @christianvogt

[openshift-ci-robot]

@karthikjeeyar: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

fix Internal registry deploy flow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@karthikjeeyar: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

fix Internal registry deploy flow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@karthikjeeyar: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/ceph-storage-plugin	8147557	link	/test ceph-storage-plugin
ci/prow/kubevirt-plugin	8147557	link	/test kubevirt-plugin

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[karthikjeeyar]

/retest

[karthikjeeyar]

/bugzilla refresh

[openshift-ci-robot]

@karthikjeeyar: This pull request references Bugzilla bug 1933727, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.z) matches configured target release for branch (4.6.z)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1894020 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1894020 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
• bug has dependents

In response to this:

Bug 1933727: fix Internal registry deploy flow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@karthikjeeyar: This pull request references Bugzilla bug 1933727, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.z) matches configured target release for branch (4.6.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 1894020 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
• dependent Bugzilla bug 1894020 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
• bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[karthikjeeyar]

/assign @invincibleJai

[rottencandy]

/lgtm

[invincibleJai]

Thanks @karthikjeeyar looks good and have verified below scenarios

Assumption:

user with admin privileges with username kubeadmin , creates a ns ns-admin1 and ns-admin2
kubeadmin creates a self-provisioner user Developer and provides view access to ns-admin1 and edit access ns-admin2
Developer user create namespace ns-dev1 and ns-dev2

Conslusion: user logs in and able to import images from the namespace's created by loggedin user , however to import from other user's created ns then needed to run the command shown in UI oc policy add-role-to-user system:image-puller system:serviceaccount:ns-admin1:default --namespace=ns-dev1

[invincibleJai]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, karthikjeeyar, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[derekwaynecarr]

(Patch Manager) met criteria, approved.

[openshift-ci-robot]

@karthikjeeyar: All pull requests linked via external trackers have merged:

• openshift/console#8267

Bugzilla bug 1933727 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1933727: fix Internal registry deploy flow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.