Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-2361: Convert Bootstrap utility class show to PF equivalent #9515

Merged
merged 1 commit into from Jul 23, 2021
Merged

CONSOLE-2361: Convert Bootstrap utility class show to PF equivalent #9515

merged 1 commit into from Jul 23, 2021

Conversation

sg00dwin
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot requested review from bipuladh and jhadvig July 14, 2021 21:14
@openshift-ci openshift-ci bot added component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/shared Related to console-shared labels Jul 14, 2021
@sg00dwin sg00dwin changed the title CONSOLE-2361: Convert Bootstrap utility class small to PF equivalent CONSOLE-2361: Convert Bootstrap utility class show to PF equivalent Jul 14, 2021
rhamilto
rhamilto reviewed Jul 14, 2021
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Four of these could be markup changes of <span> to <div> and then there is no utility class needed?

@XiyunZhao
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 15, 2021
@XiyunZhao
Copy link

XiyunZhao commented Jul 15, 2021 •
edited

This PR has been verified on private build, and do not find any issue, add some snapshot for the scenario that will be impacted in this changes
image
image
image

@sg00dwin sg00dwin mentioned this pull request Jul 15, 2021
Merged
@sg00dwin sg00dwin force-pushed the convert-bootstrap-utilities-show branch from 5995db0 to e991f85 Compare July 20, 2021 20:04
@sg00dwin
Copy link
Member Author

/retest

@rhamilto
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2021
@rhamilto
Copy link
Member

This PR has no user visible changes, and we have general docs and px approval for this epic. @ahardin-rh @sferich888 FYI

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jul 23, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1596116 into openshift:master Jul 23, 2021
@spadgett spadgett added this to the v4.9 milestone Jul 26, 2021
@sg00dwin sg00dwin deleted the convert-bootstrap-utilities-show branch August 17, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto left review comments

@bipuladh bipuladh Awaiting requested review from bipuladh

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sg00dwin @XiyunZhao @rhamilto @spadgett @openshift-merge-robot