Add a RHEL7 Dockerfile and standardize format #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
Dockerfile.rhel
Outdated
| @@ -1,11 +1,10 @@ | |||
| FROM openshift/origin-release:golang-1.10 as build | |||
| FROM registry.svc.ci.openshift.org/openshift/release:golang-1.10 AS builder | |||
There was a problem hiding this comment.
Please look exactly like this commit (
openshift/csi-external-attacher#6). You want two docker files, one with .rhel as an extension.
ironcladlou
force-pushed
the
dockerfile-rhel
branch
from
f13eeac
to
a262020
Compare
openshift-ci-robot
added
size/S
Dockerfile.openshift.rhel7
Outdated
| FROM centos:7 | ||
| COPY --from=build /go/src/github.com/coredns/coredns/coredns /usr/bin/coredns | ||
| FROM registry.svc.ci.openshift.org/ocp/4.0:base | ||
| COPY --from=builder /go/src/github.com/coredns/coredns/coredns /usr/bin/coredns |
There was a problem hiding this comment.
You can omit the trailing /coredns and just have /usr/bin/ as the destination.
| @@ -0,0 +1,13 @@ | |||
| FROM registry.svc.ci.openshift.org/openshift/release:golang-1.10 AS builder | |||
There was a problem hiding this comment.
You can do Dockerfile and Dockerfile.rhel, unless there is a docker file in the repo already that you don't want to overwrite.
There was a problem hiding this comment.
There's already a Dockerfile
|
|
||
| ENTRYPOINT ["/usr/bin/coredns"] | ||
|
|
||
| LABEL io.k8s.display-name="CoreDNS" \ |
There was a problem hiding this comment.
Keep the two docker files identical except for the FROM lines.
|
/retest |
|
Test terraform failure looks suspiciously flaky... /retest |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
2. Which issues (if any) are related?
3. Which documentation changes (if any) need to be made?