Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.11] Bug 2102782: UPSTREAM: 2101343: fix: changed the csistoragecapacity check namespace #53

Merged
merged 1 commit into from
Jul 1, 2022
Merged

[release-4.11] Bug 2102782: UPSTREAM: 2101343: fix: changed the csistoragecapacity check namespace #53

merged 1 commit into from
Jul 1, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #52

/assign jsafrane

@nbalacha
UPSTREAM: 753: fix: changed the csistoragecapacity check namespace
59cae8a 
The CSIStorageCapacity v1 check was attampting to create an invalid
object in the default namespace. This would fail if the pod did not
have permissions to the namespace. This will now use the namespace
specified in the NAMESPACE env variable.

Signed-off-by: N Balachandran <nibalach@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 30, 2022
Merged
@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2022

@openshift-cherrypick-robot: Bugzilla bug 2101343 has been cloned as Bugzilla bug 2102782. Retitling PR to link against new bug.
/retitle [release-4.11] Bug 2102782: UPSTREAM: 2101343: fix: changed the csistoragecapacity check namespace

In response to this:

[release-4.11] Bug 2101343: UPSTREAM: 2101343: fix: changed the csistoragecapacity check namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.11] Bug 2101343: UPSTREAM: 2101343: fix: changed the csistoragecapacity check namespace [release-4.11] Bug 2102782: UPSTREAM: 2101343: fix: changed the csistoragecapacity check namespace Jun 30, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 30, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2102782, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2101343 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2101343 targets the "4.12.0" release, which is one of the valid target releases: 4.12.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to this:

[release-4.11] Bug 2102782: UPSTREAM: 2101343: fix: changed the csistoragecapacity check namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dobsonj and gnufied June 30, 2022 16:11
@dobsonj
Copy link
Member

dobsonj commented Jun 30, 2022

/lgtm
/assign @jsafrane

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@jsafrane
Copy link

/approved

@jsafrane
Copy link

jsafrane commented Jul 1, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2022
@jsafrane
Copy link

jsafrane commented Jul 1, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2022

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ovirt 59cae8a link false /test e2e-ovirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

1 similar comment
@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2022

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ovirt 59cae8a link false /test e2e-ovirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mfojtik mfojtik added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jul 1, 2022
@openshift-ci openshift-ci bot merged commit 86277ec into openshift:release-4.11 Jul 1, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2102782 has been moved to the MODIFIED state.

In response to this:

[release-4.11] Bug 2102782: UPSTREAM: 2101343: fix: changed the csistoragecapacity check namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobsonj dobsonj Awaiting requested review from dobsonj

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@jsafrane jsafrane

@dobsonj dobsonj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@openshift-cherrypick-robot @dobsonj @jsafrane @mfojtik @nbalacha