Bug 1806751: Archive data-dir if target member is unstarted

[retroflexer]

Please read https://github.com/etcd-io/etcd/blob/master/CONTRIBUTING.md#contribution-flow.

[hexfusion]

In general, I wonder how useful this backup is if it is not matched with the static pod resources. In the case of encrypted datastore it would be more or less useless right?

Should we consider performing a more robust backup procedure? Regardless of the existence of this backup would require documentation on what this backup it is and how it can be used in the case of failure. In that failure case what can we guarantee about this data? I think we can guarantee it is better than nothing.

So my question is. Should we just document this procedure (manual) before restore and have the operator just nuke it?

[retroflexer]

@hexfusion well, it is a conflict between keeping the instructions simple (4th grade English ☺️) and keeping the logic simple. For 4.4, I am fine if we just take the documentation route.

[hexfusion]

Yeah I hear you it's just when folks ask how they use this backup we need to have an answer. Something to talk about.

[retroflexer]

This is not going to work because we bail out if the data-dir is already present at the beginning.

/hold

[deads2k]

/lgtm

Get your bugs in order and be prepared to pick.

[hexfusion]

/retest

[hexfusion]

/approve

[deads2k]

This is not going to work because we bail out if the data-dir is already present at the beginning.

/hold

fixed

/hold cancel

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@retroflexer: This pull request references Bugzilla bug 1806751, which is invalid:

• expected Bugzilla bug 1806751 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1806751: Archive data-dir if target member is unstarted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[retroflexer]

/cherry-pick openshift-4.4

[openshift-cherrypick-robot]

@retroflexer: once the present PR merges, I will cherry-pick it on top of openshift-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick openshift-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hexfusion]

/bugzilla refresh

[openshift-ci-robot]

@hexfusion: This pull request references Bugzilla bug 1806751, which is invalid:

• expected Bugzilla bug 1806751 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[hexfusion]

/bugzilla refresh

[openshift-ci-robot]

@hexfusion: This pull request references Bugzilla bug 1806751, which is invalid:

• expected Bugzilla bug 1806751 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hexfusion]

/refresh

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[hexfusion]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, hexfusion, retroflexer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hexfusion]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@retroflexer: All pull requests linked via external trackers have merged. Bugzilla bug 1806751 has been moved to the MODIFIED state.

In response to this:

Bug 1806751: Archive data-dir if target member is unstarted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@retroflexer: #29 failed to apply on top of branch "openshift-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	openshift-tools/pkg/discover-etcd-initial-cluster/initial-cluster.go
Falling back to patching base and 3-way merge...
Auto-merging openshift-tools/pkg/discover-etcd-initial-cluster/initial-cluster.go
CONFLICT (content): Merge conflict in openshift-tools/pkg/discover-etcd-initial-cluster/initial-cluster.go
Patch failed at 0001 Archive data-dir if target member is unstarted

In response to this:

/cherry-pick openshift-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.