Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETCD-200: Bump etcd v3.4.16 to go 1.15 #86

Merged
merged 3 commits into from
Jun 24, 2021

Conversation

hexfusion
Copy link

@hexfusion hexfusion commented Jun 18, 2021

@openshift-ci openshift-ci bot requested review from crawford and deads2k June 18, 2021 18:34
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2021
@hexfusion hexfusion changed the title Bump etcd v3.4.16 to go 1.15 ETCD-200: Bump etcd v3.4.16 to go 1.15 Jun 18, 2021
@hexfusion
Copy link
Author

/retest

1 similar comment
@lilic
Copy link

lilic commented Jun 21, 2021

/retest

@hexfusion
Copy link
Author

Looks like a bot replaced go 1.12, speaking with team about this now.

openshift/release@5d38cac#diff-794be732a8785c316a58f819bab6d435ff0fceb9b829a5fdc89184cc3eade1b7

@hexfusion
Copy link
Author

/retest

@hexfusion
Copy link
Author

/hold
/retest

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2021
@hexfusion
Copy link
Author

hexfusion commented Jun 21, 2021

openshift-eng/ocp-build-data#968 merged so this should be resolved.

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2021

@hexfusion: The /test command needs one or more targets.
The following commands are available to trigger jobs:

  • /test configmap-scale
  • /test e2e-aws
  • /test e2e-aws-serial
  • /test e2e-aws-upgrade
  • /test images
  • /test unit

Use /test all to run all jobs.

In response to this:

openshift-eng/ocp-build-data#968 merged so this should be resolved.

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Author

/test unit

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2021
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
Copy link
Author

/test unit

1 similar comment
@hexfusion
Copy link
Author

/test unit

@hexfusion
Copy link
Author

/hold working through some unit test flakes upstream... etcd-io#13139

@hexfusion
Copy link
Author

/test unit

@hexfusion
Copy link
Author

/retest

@lilic
Copy link

lilic commented Jun 24, 2021

Seems like it passed now. 🎉

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, lilic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hexfusion
Copy link
Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit eac0253 into openshift:openshift-4.9 Jun 24, 2021
@hexfusion hexfusion deleted the bump-go-1.15 branch June 24, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants