Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETCD-200: ci-operator/config/openshift/etcd: use golang 1.15 #19457

Merged
merged 1 commit into from
Jun 19, 2021

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Jun 18, 2021

openshift/etcd#83 bumped etcd to v3.4.16 which has been tested upstream with both go 1.12 and go 1.15. This PR updates the build/testing with go 1.15 on our way to an eventual etcd 3.5.0 bump for k8s 1.22.

Signed-off-by: Sam Batschelet sbatsche@redhat.com

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2021
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion hexfusion changed the title ci-operator/config/openshift/etcd: use golang 1.15 ETCD-200: ci-operator/config/openshift/etcd: use golang 1.15 Jun 18, 2021
@hexfusion
Copy link
Contributor Author

cc @marun

@marun
Copy link
Contributor

marun commented Jun 19, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, marun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d666449 into openshift:master Jun 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2021

@hexfusion: Updated the ci-operator-4.9-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-etcd-openshift-4.9.yaml using file ci-operator/config/openshift/etcd/openshift-etcd-openshift-4.9.yaml

In response to this:

openshift/etcd#83 bumped etcd to v3.4.16 which has been tested upstream with both go 1.12 and go 1.15. This PR updates the build/testing with go 1.15 on our way to an eventual etcd 3.5.0 bump for k8s 1.22.

Signed-off-by: Sam Batschelet sbatsche@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2021

@hexfusion: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/pj-rehearse 592a152 link /test pj-rehearse
ci/rehearse/openshift/etcd/openshift-4.9/e2e-aws 592a152 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hexfusion hexfusion deleted the bump-etcd-go-1.15 branch June 19, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants