Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the operand image to catch up on 2 upstream fixes #167

Merged

Conversation

@alebedev87
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2022
@openshift-ci openshift-ci bot requested review from frobware and miheer July 22, 2022 14:40
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2022
@alebedev87 alebedev87 force-pushed the test-upstream-pr-2811-catchup branch from a1a9430 to f2c7c1d Compare July 25, 2022 09:19
@alebedev87 alebedev87 force-pushed the test-upstream-pr-2811-catchup branch from f2c7c1d to ce7cad2 Compare July 27, 2022 13:26
@alebedev87
Copy link
Contributor Author

/retest

1 similar comment
@alebedev87
Copy link
Contributor Author

/retest

@alebedev87 alebedev87 closed this Jul 28, 2022
@alebedev87 alebedev87 reopened this Jul 28, 2022
@alebedev87 alebedev87 force-pushed the test-upstream-pr-2811-catchup branch from ce7cad2 to f24728a Compare July 28, 2022 08:20
@alebedev87
Copy link
Contributor Author

OCP 4.12 is already used as the cluster version for CI.
OLM catalogsource POD is not ready for the enforced Pod Security Profile:

message: 'couldn''t ensure registry server - error ensuring pod: : error creating
    new pod: oo-tdm8q-: pods "oo-tdm8q-zsgcn" is forbidden: violates PodSecurity "restricted:v1.24":
    allowPrivilegeEscalation != false (container "registry-server" must set securityContext.allowPrivilegeEscalation=false),
    unrestricted capabilities (container "registry-server" must set securityContext.capabilities.drop=["ALL"]),
    runAsNonRoot != true (pod or container "registry-server" must set securityContext.runAsNonRoot=true),
    seccompProfile (pod or container "registry-server" must set securityContext.seccompProfile.type
    to "RuntimeDefault" or "Localhost")'

@alebedev87 alebedev87 changed the title DO NOT MERGE: test catch up on the merged version of upstream PR#2811 [WIP] Test catch up on the merged version of upstream PR#2811 Jul 28, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2022
@alebedev87
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2022
@alebedev87 alebedev87 changed the title [WIP] Test catch up on the merged version of upstream PR#2811 [WIP] Update operand to 0.12.0 + 2 upstream fixes Jul 28, 2022
@alebedev87 alebedev87 changed the title [WIP] Update operand to 0.12.0 + 2 upstream fixes [WIP] Update the operand image to catch up 2 upstream fixes Jul 28, 2022
@alebedev87 alebedev87 force-pushed the test-upstream-pr-2811-catchup branch from f24728a to 280c3b3 Compare July 29, 2022 06:48
@alebedev87 alebedev87 changed the title [WIP] Update the operand image to catch up 2 upstream fixes [WIP] Update the operand image to catch up on 2 upstream fixes Jul 29, 2022
@alebedev87 alebedev87 force-pushed the test-upstream-pr-2811-catchup branch from 280c3b3 to 1b2bc9e Compare July 29, 2022 06:49
@alebedev87 alebedev87 changed the title [WIP] Update the operand image to catch up on 2 upstream fixes Update the operand image to catch up on 2 upstream fixes Jul 29, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2022
@quarterpin
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 29, 2022
@alebedev87
Copy link
Contributor Author

Infoblox test:

export DNS_PROVIDER=INFOBLOX
$ make test-e2e
go test \
-ldflags "-X github.com/openshift/external-dns-operator/pkg/version.SHORTCOMMIT=1b2bc9e -X github.com/openshift/external-dns-operator/pkg/version.COMMIT=1b2bc9ed59e7914af3345ca153cf84c17673c861" \
-timeout 1h \
-count 1 \
-v \
-tags e2e \
-run "" \
./test/e2e

Ensuring hosted zone: 1659079833.1b2bc9e.example-test.info
=== RUN   TestOperatorAvailable
--- PASS: TestOperatorAvailable (2.25s)
=== RUN   TestExternalDNSWithRoute
--- PASS: TestExternalDNSWithRoute (46.39s)
=== RUN   TestExternalDNSRecordLifecycle
--- PASS: TestExternalDNSCustomIngress (17.00s)
=== RUN   TestExternalDNSWithRouteV1Alpha1
--- PASS: TestExternalDNSWithRouteV1Alpha1 (16.56s)
=== RUN   TestExternalDNSSecretCredentialUpdate
--- PASS: TestExternalDNSSecretCredentialUpdate (61.69s)
PASS
Deleting hosted zone: 1659079833.1b2bc9e.example-test.info
ok  	github.com/openshift/external-dns-operator/test/e2e	230.372s

@alebedev87
Copy link
Contributor Author

GCP test:

$ export DNS_PROVIDER=GCP
$ make test-e2e
go test \
-ldflags "-X github.com/openshift/external-dns-operator/pkg/version.SHORTCOMMIT=1b2bc9e -X github.com/openshift/external-dns-operator/pkg/version.COMMIT=1b2bc9ed59e7914af3345ca153cf84c17673c861" \
-timeout 1h \
-count 1 \
-v \
-tags e2e \
-run "" \
./test/e2e

Ensuring hosted zone: 1659080887.1b2bc9e.example-test.info
=== RUN   TestOperatorAvailable
--- PASS: TestOperatorAvailable (2.25s)
=== RUN   TestExternalDNSWithRoute
--- PASS: TestExternalDNSWithRoute (16.29s)
=== RUN   TestExternalDNSRecordLifecycle
--- PASS: TestExternalDNSRecordLifecycle (76.28s)
=== RUN   TestExternalDNSCustomIngress
--- PASS: TestExternalDNSCustomIngress (17.21s)
=== RUN   TestExternalDNSWithRouteV1Alpha1
--- PASS: TestExternalDNSWithRouteV1Alpha1 (16.18s)
=== RUN   TestExternalDNSSecretCredentialUpdate
--- PASS: TestExternalDNSSecretCredentialUpdate (76.43s)
PASS
Deleting hosted zone: 1659080887.1b2bc9e.example-test.info
ok  	github.com/openshift/external-dns-operator/test/e2e	212.040s

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2022

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alebedev87
Copy link
Contributor Author

Oh, the OLM was fixed, nice :)

@alebedev87
Copy link
Contributor Author

/label docs-approved
/label px-approved

No changes on this side

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jul 29, 2022
@Miciah
Copy link
Contributor

Miciah commented Jul 29, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2022
@openshift-merge-robot openshift-merge-robot merged commit d771984 into openshift:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants