Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM 2811: Handle the migration to the new TXT format. Catch up to the merged version #44

Conversation

alebedev87
Copy link

@alebedev87 alebedev87 commented Jul 22, 2022

The merged version of the upstream kubernetes-sigs#2811 drifted from the cherry pick we used in #43.
The goal of this PR is to catch up on this drift.

Test PR: openshift/external-dns-operator#167

…sing records.

Catch up to the merged version
@openshift-ci openshift-ci bot requested review from frobware and miheer July 22, 2022 14:23
@openshift-ci
Copy link

openshift-ci bot commented Jul 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 22, 2022

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alebedev87
Copy link
Author

alebedev87 commented Jul 25, 2022

Closed in favor of #45

@alebedev87 alebedev87 closed this Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant