Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the migration to the new TXT format. Catch up to the merged version #45

Conversation

alebedev87
Copy link

@alebedev87 alebedev87 commented Jul 25, 2022

@alebedev87 alebedev87 changed the title Carry patch handle missing txt record final version Handle the migration to the new TXT format. Catch up to the merged version Jul 25, 2022
@openshift-ci openshift-ci bot requested review from knobunc and rfredette July 25, 2022 09:14
@openshift-ci
Copy link

openshift-ci bot commented Jul 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2022
@alebedev87 alebedev87 force-pushed the carry-patch-handle-missing-txt-record-final-version branch from 1af8664 to 8fa7f7d Compare July 25, 2022 12:35
@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2022

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Miciah
Copy link

Miciah commented Jul 28, 2022

Thanks!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2022
@alebedev87
Copy link
Author

/label docs-approved
/label px-approved

Nothing changed on this side

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jul 28, 2022
@alebedev87
Copy link
Author

alebedev87 commented Jul 28, 2022

Putting the QE label to let the image be published, so that it can be used in the operator repository where QE will give its greenlight: PR.

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 28, 2022
@openshift-merge-robot openshift-merge-robot merged commit 906ba04 into openshift:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants