Add ServiceMonitor support to KCM #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds ServiceMonitor support to kube-controller-manager. It also cleans up the ServiceMonitor support for kube-apiserver to remove an unnecessary certificate mount, fix the cert usage parameter, and refactor the code to be uniform with other PKI logic. The ServiceMonitor has relabelling rules that mirror those provided by OCP.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
@ironcladlou: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds ServiceMonitor support to kube-controller-manager. It also
cleans up the ServiceMonitor support for kube-apiserver to remove an unnecessary
certificate mount, fix the cert usage parameter, and refactor the code to be
uniform with other PKI logic.
The ServiceMonitor has relabelling rules that mirror those provided by OCP.
Checklist
Relevant issues have been referenced.This change includes docs.This change includes unit tests.