[release-4.10] Fast-Forward from main #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is completely expected during deletion, logging it at error level makes it look like an issue, which it is not.
HO: Don't report NotFund for hostedcluster as error
The KAS needs the proxy settings to communicate with the cloud provider. However, the egress transport it uses wraps another transport that respects proxy settings which is why we need to excempt pod and service CIDR of the guest cluster to not break Konnektivity. I also tried to stop using the egress config and use the konnektivity-socks5-proxy, but that breaks SPDY connections (exec, port-forward). Ref https://issues.redhat.com/browse/HOSTEDCP-333
KAS: Set proxy, but exempt pod and service CIDR
add external-dns flags to CI install make target
sync MaxConcurrentReconciles across all controllers
enable external-dns registry
HostedCluster can optionally reference a configmap, in which case we copy the configmap to the HostedControlPlane namespace (similar to SSHKey and other fields).
When AdditionalTrustBundle is defined we create this ConfigMap to align with the behavior of regular OCP clusters and enable consumption of user-defined CA certs by the guest cluster.
When AdditionalTrustBundle is specified, we serialize the configmap and pass to the MCO bootstrap command via the default user-ca-bundle-config.yaml location - this means the MCO bootstrap will read the file when included, (the code already ignores the case where the file doesn't exist, since openshift/installer only conditionally creates the manifest)
This can be used to reference a ConfigMap that contains a user CA bundle.
The CPO and ignition server need the user CA so the registryclient can access a local registry with a self-signed cert
Adds a CLI option and corresponding volume to the operator pod, this is needed so the operator can look up release image metadata when the release image specified is locally mirrored. Note the mount path/filename were chosen to align with the expected defaults ref https://go.dev/src/crypto/x509/root_linux.go (and also current OCP docs for cert injection using operators)
In its current state, the hosted cluster config operator overwrites any changes made by the guest cluster admin to the registry configuration. This prevents changes like enabling a route or increasing the number of replicas. This commit limits what we change to things we need to change and leave everything else as is.
Currently, dump just drops a lot of files. This is useful for browsing them in the CI job output, but terrible for downloading them for local inspection, as downloading a lot of files is extremely slow, even if the files aren't big. This change makes us always create an archive of the dump to not require extending every CI job to do this manually.
The version we currently use can not compile anything and fails with errors like this: could not load export data: cannot import "math/bits" (unknown iexport format version 2), export data is newer version - update tool (compile) Note that this doesn't mean staticcheck supports generics, it just means it can be compiled with go 1.18.
Signed-off-by: David Vossel <davidvossel@gmail.com>
Registry configuration: reconcile only what we need to changes
…s-v1 Unique OpenShift vxlan port for KubeVirt Platform
Update staticcheck to a version that works with go 1.18
Dump: Always create an archive
This upgrades mkdocs/material to fix Netlify docs compilation breakages resulting from mkdocs/mkdocs#2799.
These components watch both management cluster (Machine scalable resources) and guest cluster. Originally we were pinning the images to a version that would cross any HostedCluster. This PR let us pick them from each particular payload resulting in some benefits: Each hostedCluster runs the component version that was tested with that particular kube/ocp version No additional work needed to productise the images as they com from the payload. Since CAPI CRDs should be backward compatible, having different controller versions shouldn't cause an issue. Once the CAPI image is in the payload we can do the same for it.
docs: Upgrade mkdocs/material to fix Netlify breakages
Signed-off-by: David Vossel <davidvossel@gmail.com>
…rom-payload read apiserver-network-proxy image from ocp payload
The single-hyphen flags do not work anymore due to operator-framework/operator-lifecycle-manager#2362
Fix CPO to work with 4.11
Signed-off-by: David Vossel <davidvossel@gmail.com>
Before this commit, EIP tagging failures resulting from the EIP not being found after the EIP was successfully created led to infra creation failing overall because the tagging operation was not retried. This commit adds retry logic to EIP tagging to account for the case when EIP creation succeeds but tagging fails because the AWS tagging API doesn't yet see the new EIP.
Retry EIP tagging failures during infra creation
…y-v1 AntiAffinity rules to spread KubeVirt VMs across mgmt nodes
Signed-off-by: David Vossel <davidvossel@gmail.com>
…ss-v1 Document KubeVirt Platform Ingress Setup
The olm cronjob had a prioryClass of openshift-user-critical which has a priority that is above all other controlplane components in the management cluster. Downgrade it to the standard hypershift-control-plane and add an e2e test that verifies that no pod has a priority higher than the etcd priority.
Get autoscaler/machine-approver images from the payload
Before this commit, calls to `WaitForConditionsOnHostedControlPlane()` could fail a test if an API lookup fails even though that lookup is recoverable and retried automatically. This made the test flaky. This commit fixes the code so that these retriable errors are logged but do not fail the test. This commit also moves a log message which was intended to emit during retries but was instead placed at the exit point.
Before this commit, UWM was enabled by the e2e `setup` command, which was used in the past but is no longer used. The UWM stack is thus wasting resources on management clusters used for e2e runs. This commit removes UWM from the monitoring setup for e2e tests.
Hypershift operator: Give a priority that is higher than any controlplane component
e2e: Don't fail test on transient recoverable API lookup
Fix priority class for olm cronjob and verify priorityclasses in e2e
e2e: Don't enable user workload monitoring on management clusters
|
@alvaroaleman: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@alvaroaleman: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist