Release 4.12 rebase latest #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the hcco is not available, the cpo will wait indefinitely for it to update hcp conditions to indicate that guest resources have been deleted. To solve that, the hcco will periodically update a condition to let the CPO that it's working on deletion. If the condition is not updated after a certain amount of time, the CPO gives up waiting and proceeds with the rest of the deletion.
fix(ho): Use v1alpha1 ownerRef for future CPO managed components
test: e2e: remove node checks during NodePool upgrade test
add KAS egress network policy
This reverts commit 0e8d515.
Revert "add KAS egress network policy"
HypershiftAWSLoadBalancerCrossZoneLoadBalancingEnabled applies https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.1/guide/service/annotations/ service.beta.kubernetes.io/aws-load-balancer-cross-zone-load-balancing-enabled in the load balancer services of the hosted control plane endpoints. AWS Private link requires endpoint and service endpoints to exist in the same underlying zone. To ensure that requirement is satisfied in Regions with more than 3 zones, managed services create subnets in all of them. That and having this enabled in the load balancers would make the private link communication to always succeed.
cmd: dump: include networkpolicies
Add annotation for cross zone lb
Prevent cluster deletion hangs by using heartbeat condition
This improve UX by removing the need to pre create a kube secret and require only a string as input instead. This align UX with RolesRef field
Add clarifying comment
…terval external-dns: set AWS batch internal to 10s
Signed-off-by: David Vossel <davidvossel@gmail.com>
add missing app label to HCP components
fix(ho): Set restart date annotation back
…ss-v2 Add default kubevirt guest cluster storageclass
Add support for additional allowed principals for AWS hosted cluster VPC Endpoint Services
fix(cpo): Remove storage from mgmt cluster for IBM Cloud
adjust rate interval on hypershift:controlplane:component_cpu_usage_s…
This extend existing metrics exposed by the HO to include Expose proxy, identityProviders and limited support metrics. These metrics are useful to infer symptons and point to causes when observing a fleet of clusters. E.g. Lets say we notice a subset of customers having IDP issues but no reported outages on github. We would be able to analyze the metrics and indeed say that github was having issues if we had outages fleetwide across github. These metrics are used in ROSA today. In future if they grow in a very opinionated way we might want to decouple them from the HO.
The label is dropped when reported in metrics if it doesn't have a value.
Updated secret permissions to 0640
This introduces inital support for label/tait propagation from NodePools to Nodes honouring the following functional reqs: - Propagate only once on Node creation. In future we might enable further automated or controller reconciliation. - Enable consumers to choose the labels/taints to be synced.
Expose proxy, identityProviders and limited support metrics
Add value to hosted control plane namespace label
Add support to propagate labels from NodePools to Nodes
Add ref for SLOs
…concile fix cluster csi driver reconcile
switch OLM catalogs to imagestream
This reverts commit 9eb0b94. (not needed in 4.12)
4 tasks
|
@enxebre: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
@enxebre: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist