move subnetID reconcilation for AWSEndpointServices #988

sjenning · 2022-02-08T17:30:10Z

What this PR does / why we need it:
#951 accidentally worked due to the NodePool being updated after the creation of the AWSEndpointServices, however, reconciliation of .spec.subnetIDs on AWSEndpointServices currently happens on a controller that doesn't watch AWSEndpointServices.

This moves the reconciliation of subnetIDs to the AWSEndpointServiceReconciler and adds a NodePool watch to that controller.

The mapping of NodePools <-> AWSEndpointServices is a little fragile. I'm open to suggestions.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

alvaroaleman · 2022-02-08T17:40:51Z

hypershift-operator/controllers/platform/aws/controller.go

+			return []reconcile.Request{}
+		}
+
+		// This is a pretty fragile but without a client or context with which to list the


An alternate would be to use a client and list the endpointservices here, the main drawback is that we can't handle errors

Yeah, I thought of this but we still don't avoid a fragile mapping in that the HCP namespace has to be assumed from the nodepool Namespace and the node pool clusterName. All in all, it added complexity and was still fragile.

I thought of this but we still don't avoid a fragile mapping in that the HCP namespace has to be assumed from the nodepool Namespace and the node pool clusterName

Could fetch HC from nodePool.spec.clusterName.
Then HCP_namespace(HC) is a stronger contract.
Then list endpoints.
?

That said I think I lean towards the simplicity of current approach.
It'd be good though to document this 2 dependents aws endpoints controllers at some point may be here https://hypershift-docs.netlify.app/reference/controller-architecture/

Sounds like this is acceptable for now

hypershift-operator/controllers/platform/aws/controller.go

sjenning · 2022-02-08T20:19:50Z

/retest

openshift-ci · 2022-02-08T21:29:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [alvaroaleman,sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-02-08T23:34:59Z

/retest-required