archiveFromContainer(): return possibly-wrapped os.IsNotError #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a source specified as a glob can't be found, return an error that can be identified by as an os.ErrIsNotExist, wrapped or otherwise, even if we have to drop the glob from the error string to ensure that for versions of Go that don't wrap errors. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
It is probably time we drop go 1.12.1... |
|
Thanks @nalind. I looked for |
|
and forgot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a source specified as a glob can't be found, return an error that can be identified by as an
os.ErrIsNotExist, wrapped or otherwise, even if we have to drop the glob from the error string to ensure that for versions of Go that don't wrap errors.Unit tests for the
dockerclientpackage were failing with Go 1.12 without this patch. See the 1.13 release note on the use of the%wformat specifier.