Reuse archives & refactor archive checks + some fixes #264
Conversation
Signed-off-by: Pavel Simovec <psimovec@redhat.com>
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
|
/retest |
|
/retest |
Signed-off-by: Pavel Simovec <psimovec@redhat.com>
psimovec
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
| t.Fatal(prettyName, ": No patterns to check") | ||
| } | ||
| for _, pattern := range patterns { | ||
| err := checkArchiveFiles(t, prettyName, check, pattern, archive) |
There was a problem hiding this comment.
Just minor - would it make sense to move the checkArchiveFiles (and probably also the latestArchiveFiles) function to bugs_test.go?
I am not very experienced with Go tests and testing, but the main_test.go looks more like some test utils file (if it is so then we can leave these functions there) .
There was a problem hiding this comment.
I understand it as test utils file now too, checkArchiveFiles could make sense to move to bugs.go, I don't think so about latestArchiveFiles (I could want to import it to different test file).. But it would make sense to move all the util functions from main.go to different files, as it starts getting unnecessarily big, and it's not very readable what main.go is.
There was a problem hiding this comment.
(should be done in different PR)
There was a problem hiding this comment.
I agree with @psimovec on this one. For now, it is fine, but it is starting to become a huge and not readable file.
| t.Fatal(prettyName, ": No patterns to check") | ||
| } | ||
| for _, pattern := range patterns { | ||
| err := checkArchiveFiles(t, prettyName, check, pattern, archive) |
There was a problem hiding this comment.
I agree with @psimovec on this one. For now, it is fine, but it is starting to become a huge and not readable file.
|
/lgtm cancel |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: psimovec, rluders The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Signed-off-by: Pavel Simovec psimovec@redhat.com