Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1932775: Refactor #335

Merged
merged 8 commits into from
Mar 4, 2021
Merged

[release-4.6] Bug 1932775: Refactor #335

merged 8 commits into from
Mar 4, 2021

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Feb 9, 2021 •
edited
Loading

This PR backports the first few steps of the refactor introduced in 4.7.
Main goal is to greatly reduce the amount of merge conflicts during backports, and also to make the codebase clearer and by consequence the future backport PRs clearer and easier to create.
It separates the clusterconfig.go into multiple smaller files, and modifies how clients are handled.

There is NO NEWLY added gatherer in this PR, its just structures the gatherers in a friendlier way.

Businesses reason: Because 4.6 has Extended Update Support having a more maintainable codebase will save us a considerable amount of time.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample archive

  • not necessary

Documentation

  • TODO

Unit Tests

  • not necessary

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Not necessary

References

@openshift-ci-robot
Copy link
Contributor

@0sewa0: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.6] Refactor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2021
@0sewa0
Copy link
Contributor Author

0sewa0 commented Feb 10, 2021

/retest

1 similar comment
@0sewa0
Copy link
Contributor Author

0sewa0 commented Feb 10, 2021

/retest

@0sewa0 0sewa0 force-pushed the 4_6_refactor branch 2 times, most recently from d04c72d to bd43343 Compare February 18, 2021 10:58
@0sewa0 0sewa0 changed the title [release-4.6] Refactor [release-4.6] Bug 1932775: Refactor Feb 25, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Feb 25, 2021
@openshift-ci-robot
Copy link
Contributor

@0sewa0: This pull request references Bugzilla bug 1932775, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1907876 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1907876 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

In response to this:

[release-4.6] Bug 1932775: Refactor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 25, 2021
@0sewa0
Copy link
Contributor Author

0sewa0 commented Feb 25, 2021

/retest

@0sewa0 0sewa0 force-pushed the 4_6_refactor branch 2 times, most recently from 7330893 to ba57a67 Compare March 1, 2021 09:04
@openshift-ci-robot
Copy link
Contributor

@0sewa0: This pull request references Bugzilla bug 1932775, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1907876 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1907876 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

In response to this:

[release-4.6] Bug 1932775: Refactor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0sewa0
Copy link
Contributor Author

0sewa0 commented Mar 1, 2021

/retest

@openshift-ci-robot
Copy link
Contributor

@0sewa0: This pull request references Bugzilla bug 1932775, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1907876 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1907876 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

In response to this:

[release-4.6] Bug 1932775: Refactor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@0sewa0: This pull request references Bugzilla bug 1932775, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1907876 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1907876 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

In response to this:

[release-4.6] Bug 1932775: Refactor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0sewa0
Copy link
Contributor Author

0sewa0 commented Mar 2, 2021

/retest

2 similar comments
@0sewa0
Copy link
Contributor Author

0sewa0 commented Mar 2, 2021

/retest

@0sewa0
Copy link
Contributor Author

0sewa0 commented Mar 2, 2021

/retest

@tremes
Copy link
Contributor

tremes commented Mar 2, 2021

I experimented with this one locally. I compared the archive (for the same cluster) before and after this change and I didn't see any problem. I also tried to go through the code changes carefully.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2021
@rluders
Copy link
Contributor

rluders commented Mar 2, 2021

Tested locally.
/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, rluders, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [0sewa0,rluders,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@0sewa0
Copy link
Contributor Author

0sewa0 commented Mar 3, 2021

/retest

@derekwaynecarr
Copy link
Member

(Patch-Manager) approved

@derekwaynecarr derekwaynecarr added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 4, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 21ca4a2 into openshift:release-4.6 Mar 4, 2021
@openshift-ci-robot
Copy link
Contributor

@0sewa0: All pull requests linked via external trackers have merged:

Bugzilla bug 1932775 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1932775: Refactor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremes tremes tremes left review comments

@natiiix natiiix Awaiting requested review from natiiix

@rluders rluders Awaiting requested review from rluders

Assignees

@rluders rluders

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@0sewa0 @openshift-ci-robot @tremes @rluders @openshift-bot @derekwaynecarr @openshift-merge-robot