Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1782151 - override node selector #59

Merged
merged 1 commit into from Jan 2, 2020
Merged

Bug 1782151 - override node selector #59

merged 1 commit into from Jan 2, 2020

Conversation

iNecas
Copy link
Contributor

@iNecas iNecas commented Dec 11, 2019

To ensure the deployment works properly in case of default node selector
is set.

@iNecas
Bug 1782151 - override node selector
53cfc74 
To ensure the deployment works properly in case of default node selector
is set.
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 11, 2019
@iNecas
Copy link
Contributor Author

iNecas commented Dec 11, 2019

Followed pattern of other operators (such as https://github.com/openshift/cluster-monitoring-operator/blob/670ebc4f5998613d21b49420f52415eddb26c4c7/manifests/0000_50_cluster_monitoring_operator_01-namespace.yaml)

@iNecas
Copy link
Contributor Author

iNecas commented Dec 11, 2019

@quarckster could you help with verification based on the BZ description?

@iNecas
Copy link
Contributor Author

iNecas commented Dec 12, 2019

/retest

@quarckster
Copy link
Contributor

@iNecas I verified it on 4.3.0-0.nightly-2019-12-12-021332. I followed steps described in this comment https://bugzilla.redhat.com/show_bug.cgi?id=1782151#c0. I patched openshift-insights namespace metadata with openshift.io/node-selector: "" then I restarted insights-operator operator and it was successfully scheduled.

@iNecas
Copy link
Contributor Author

iNecas commented Dec 12, 2019

/lgtm based on @quarckster comment

@iNecas
Copy link
Contributor Author

iNecas commented Dec 13, 2019

/lgtm

@openshift-ci-robot
Copy link
Contributor

@iNecas: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iNecas
Copy link
Contributor Author

iNecas commented Dec 13, 2019

Ok, I give up, @mfojtik / @derekwaynecarr / @smarterclayton: anyone wants to approve this one? Should be XS

@mfojtik
Copy link
Member

mfojtik commented Jan 2, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iNecas, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 095b027 into openshift:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@mfojtik mfojtik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@iNecas @quarckster @openshift-ci-robot @mfojtik @openshift-merge-robot