Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rhcos: Pin to previous version #1325

Closed
wants to merge 1 commit into from

Conversation

cgwalters
Copy link
Member

Something went wrong with our new build system; looks like broken
networking in the initramfs. Pin for now.

Something went wrong with our new build system; looks like broken
networking in the initramfs.  Pin for now.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 27, 2019
@ashcrow
Copy link
Member

ashcrow commented Feb 27, 2019

/cc @darkmuggle

Copy link
Member

@ashcrow ashcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgwalters
Copy link
Member Author

I verified with a local libvirt run this got my master machine to Ignite again. Going to dive into what changed in the builds now.

@wking
Copy link
Member

wking commented Feb 27, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2019
@cgwalters
Copy link
Member Author

cgwalters commented Feb 27, 2019

This passed the installer just fine, so if it flakes on e2e tests I vote we force it in.

@crawford
Copy link
Contributor

/hold

I don't like the precedent this sets. The installer cannot be the backstop for a CI failure. Give me a few minutes to figure out the next move. I want to hold this for a second though.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2019
@cgwalters
Copy link
Member Author

The installer cannot be the backstop for a CI failure.

Agreed, and we have plans to fix it.

As far as "right now" fixes we could revert the build...it's also ugly.

@ashcrow
Copy link
Member

ashcrow commented Feb 27, 2019

As far as "right now" fixes we could revert the build...it's also ugly.

Agreed.

@crawford
Copy link
Contributor

We're going to hold here and wait for an OS fix. I'm going to leave this open in case something goes very wrong and we end up needing this change, but I do not intend to merge this at this point.

/approve cancel
/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2019
@wking
Copy link
Member

wking commented Feb 27, 2019

We're going to hold here and wait for an OS fix.

Do we have a time estimate on that fix? Even if it's just reverting something, I expect it will take time to build a new image and push it through the RHCOS release pipeline. Are we ok with an org-wide e2e-aws outage while we wait for that? I'm personally fine landing this as a temporary stop-gap, reverting it once the RHCOS pipeline is fixed for this particular issue, and then using #1286 consuming e2e-aws-gated RHCOS pins to avoid issues like this in the future.

@ashcrow
Copy link
Member

ashcrow commented Feb 27, 2019

It's as soon as possible. In the meantime @darkmuggle is pausing the pipeline and removing the offending build.

Yeah, it's not ideal, but as noted before, when there are issues with masters or other components we keep moving forward to fix them rather than falling back to previous working code. Granted, if this takes "too long" we will absolutely revert.

@wking
Copy link
Member

wking commented Feb 27, 2019

In the meantime @darkmuggle is pausing the pipeline and removing the offending build.

Do we have a time estimate on that? Might be faster than waiting on CI here anyway ;)

@ashcrow
Copy link
Member

ashcrow commented Feb 27, 2019

He's doing it right now ... My guess is around 10 minutes.

@cgwalters
Copy link
Member Author

coreos/coreos-assembler#375

@ashcrow
Copy link
Member

ashcrow commented Feb 27, 2019

The offending build has been removed, the current pipeline is frozen while we test a fix that just merged to coreos-assembler.

The latest listed image from the pipeline should be stable again.

@cgwalters cgwalters closed this Feb 27, 2019
@ashcrow
Copy link
Member

ashcrow commented Feb 27, 2019

Latest listed build is 47.334 which is what this PR wanted to pin on. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants