Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1813012: Remove unused flags previously needed for etcd static pod #4063

Merged
merged 1 commit into from Sep 1, 2020
Merged

Bug 1813012: Remove unused flags previously needed for etcd static pod #4063

merged 1 commit into from Sep 1, 2020

Conversation

retroflexer
Copy link
Contributor

@retroflexer retroflexer commented Aug 18, 2020 •
edited

The images for kube-client-agent and setup-etcd-env are no longer needed for either MCO or CEO.

@retroflexer
Copy link
Contributor Author

/retest

@retroflexer
Copy link
Contributor Author

For this PR to work, MCO will need to make these arguments optional.
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2020
@retroflexer retroflexer mentioned this pull request Aug 20, 2020
Closed
@retroflexer retroflexer changed the title Remove unused flags previously used for etcd static pod Remove unused flags previously needed for etcd static pod Aug 24, 2020
@hexfusion
Copy link
Contributor

hexfusion commented Aug 26, 2020 •
edited

PR openshift/machine-config-operator#1933 landed

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2020
@hexfusion
Copy link
Contributor

/test all

@hexfusion
Copy link
Contributor

/refresh

@hexfusion
Copy link
Contributor

/test e2e-aws

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2020
@retroflexer
Copy link
Contributor Author

Since PR #4062 is merged now, I rebased so that this PR can progress.

@retroflexer retroflexer changed the title Remove unused flags previously needed for etcd static pod Bug 1813012: Remove unused flags previously needed for etcd static pod Aug 26, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 26, 2020
@openshift-ci-robot
Copy link
Contributor

@retroflexer: This pull request references Bugzilla bug 1813012, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1813012: Remove unused flags previously needed for etcd static pod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 26, 2020
@openshift-ci-robot
Copy link
Contributor

@retroflexer: This pull request references Bugzilla bug 1813012, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1813012: Remove unused flags previously needed for etcd static pod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@retroflexer
Copy link
Contributor Author

/test e2e-gcp
/test e2e-azure
/test e2e-aws-upi
/test e2e-metal
/test e2e-vsphere

@retroflexer
Copy link
Contributor Author

/retest

@retroflexer
Copy link
Contributor Author

/retest

@hexfusion
Copy link
Contributor

/test e2e-ovirt

@retroflexer
Copy link
Contributor Author

/test e2e-gcp
/test e2e-azure
/test e2e-aws-upi
/test e2e-metal
/test e2e-vsphere

@retroflexer
Copy link
Contributor Author

/assign @abhinavdahiya

@retroflexer
Copy link
Contributor Author

/test e2e-azure
/test e2e-vsphere

@retroflexer
Copy link
Contributor Author

/retest

@abhinavdahiya
Copy link
Contributor

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 1, 2020 •
edited

@retroflexer: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure 6870de2 link /test e2e-azure
ci/prow/e2e-vsphere 6870de2 link /test e2e-vsphere
ci/prow/e2e-crc 6870de2 link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b934ccc into openshift:master Sep 1, 2020
@openshift-ci-robot
Copy link
Contributor

@retroflexer: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1813012 has not been moved to the MODIFIED state.

In response to this:

Bug 1813012: Remove unused flags previously needed for etcd static pod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs vrutkovs mentioned this pull request Sep 2, 2020
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 28, 2020
Merged
@retroflexer retroflexer deleted the cleanup-unused-mco-flags branch October 29, 2020 00:21
@openshift-ci-robot openshift-ci-robot mentioned this pull request Nov 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@jstuever jstuever Awaiting requested review from jstuever

Assignees

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@retroflexer @hexfusion @openshift-ci-robot @abhinavdahiya @openshift-bot @openshift-merge-robot