Bug 1813012: Remove unused etcd discovery domain #4067
Conversation
|
/retest |
|
/test e2e-ovirt |
|
/retest |
1 similar comment
|
/retest |
|
/reetest |
|
/retest |
|
/approve |
|
/test e2e-metal-ipi |
|
/test e2e-ovirt |
|
/test e2e-gcp |
|
So e2e-metal-ipi, e2e-openstack, e2e-vsphere each one is failing to bootstrap, and all these use hosted-networking. so it is possible something needs to be fixed here. |
|
This is failing in the on-prem platforms because we're still using this field to get the cluster domain. For example: https://github.com/openshift/machine-config-operator/blob/9a6ef99e2dbac4c6c00ba890894ed003390f5c0a/templates/common/baremetal/files/baremetal-coredns-corefile.yaml#L8 If there's another place we can get that in MCO then we can certainly switch, but in the meantime the ci failures are legitimate. |
If you look at the DNS cluster config it includes the basedomain for the cluster, https://github.com/openshift/api/blob/e9036946d01a899fa1eacaddaf79310f47dff04f/config/v1/types_dns.go#L24-L31 I seems like that is what you really want.. |
|
/hold This PR cannot be merged until MCO finds a different way to extract base domain. |
openshift-ci-robot
added
the
do-not-merge/hold
|
Ben has a PR on MCO to move away from using EtcdDiscoveryDomain. Thanks, Ben. Once that merges, we can proceed with this PR. |
retroflexer
force-pushed
the
remove-unused-etcd-discovery-domain
branch
from
8011c6b
to
768e56a
Compare
|
Since PR #4062 is merged now, I rebased so that this PR can progress. |
retroflexer
changed the title
openshift-ci-robot
added
bugzilla/severity-medium
|
@retroflexer: This pull request references Bugzilla bug 1813012, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@retroflexer: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-aws-workers-rhel7 |
|
/test e2e-aws |
|
@abhinavdahiya could you PTAL and possibly approve? |
|
/test e2e-gcp |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test e2e-aws-upi |
2 similar comments
|
/test e2e-aws-upi |
|
/test e2e-aws-upi |
|
not sure why this was not tagged as it has been approved I think its time we get this done. /lgtm |
|
/retest |
|
@abhinavdahiya do you see why e2e-aws-upi is failing? The apiserver is not coming up after the bootstrap, but I can't see how any of my changes is causing the failure. |
we can see that all the instances are waiting to ignite, failing to connect to the bootstrap instance's machine-config-server to get ignition. This means that bootstrap host could not be reached to gather bootstrap log bundle, and it looks like bootstrap ec2 instance console logs are not captured. So i think the bootstrap host is also maybe failing to boot.. |
|
This may be a similar issue to the one that was fixed recently with the azure upi tests. The upi tests are still using version 2.1.0 for the ignition config files. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@retroflexer: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@retroflexer: All pull requests linked via external trackers have merged:
Bugzilla bug 1813012 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
With openshift#4067, the etcdDiscoveryDomain field is no longer set in the infrastructure.config.openshift.io manifest. However, the cluster-network-operator relies on that field when syncing the status of proxy.config.openshift.io [1]. [1] https://github.com/openshift/cluster-network-operator/blob/c23495cf6e6ffeffc0290c85ee4608102f7b47d1/pkg/util/proxyconfig/no_proxy.go#L113
With openshift#4067, the etcdDiscoveryDomain field is no longer set in the infrastructure.config.openshift.io manifest. However, the cluster-network-operator relies on that field when syncing the status of proxy.config.openshift.io [1]. [1] https://github.com/openshift/cluster-network-operator/blob/c23495cf6e6ffeffc0290c85ee4608102f7b47d1/pkg/util/proxyconfig/no_proxy.go#L113
etcd has not been using DNS entries since 4.4 and EtcdDiscoveryDomain has been a redundant flag. This PR attempts to get rid of the unused flag.
This is an attempt to get #4024 split into smaller PRs to understand the build errors.