Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1813012: Remove the unused flags and images used in the previous releases for etcd #2048

Conversation

retroflexer
Copy link
Contributor

- What I did
Removed unused flags and images for etcd, cluster-etcd-operator and kube-client-agent.
- How to verify it
Install or upgrade a cluster. MCO should come up fine without the removed flags.
- Description for the changelog

Remove unused flags and images needed in the past for etcd.

@retroflexer retroflexer changed the title Remove the unused flags and images used in the previous releases for etcd Bug 1813012: Remove the unused flags and images used in the previous releases for etcd Sep 1, 2020
@hexfusion
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2020
@hexfusion
Copy link
Contributor

/lgtm cancel
we should figure out why okd is failing to bootstrap

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2020
@hexfusion
Copy link
Contributor

@vrutkovs did we break okd?

@hexfusion
Copy link
Contributor

Maybe here?
f7bdd40

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 1, 2020

@retroflexer: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws 6f1b096 link /test okd-e2e-aws
ci/prow/e2e-ovn-step-registry 6f1b096 link /test e2e-ovn-step-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hexfusion
Copy link
Contributor

Sep 01 19:55:22 ip-10-0-60-127 systemd[1]: Started Bootstrap a Kubernetes cluster.
Sep 01 19:55:24 ip-10-0-60-127 bootkube.sh[1802]: F0901 19:55:24.077863 1 image.go:32] error: error: Unknown name requested, could not find kube-client-agent in UpdatePayload

Looks like the installer[1] is not updated for OKD?

[1] https://github.com/openshift/installer/pull/4063/files

@hexfusion
Copy link
Contributor

/test e2e-aws

@vrutkovs
Copy link
Member

vrutkovs commented Sep 2, 2020

Looks like the installer[1] is not updated for OKD?

Yes, OKD 4.6 installer needs to be rebased. I'll include openshift/installer#4063 in my next rebase (openshift/installer#4116), so OKD test can be skipped

/skip

@retroflexer
Copy link
Contributor Author

retroflexer commented Sep 2, 2020

Thanks @vrutkovs and @hexfusion for the due diligence. Now all the other tests are passing.

@hexfusion
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2020
@hexfusion
Copy link
Contributor

/assign @kikisdeliveryservice

@runcom
Copy link
Member

runcom commented Sep 2, 2020

/approve

@runcom
Copy link
Member

runcom commented Sep 2, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, retroflexer, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels Sep 2, 2020
@openshift-ci-robot
Copy link
Contributor

@runcom: This pull request references Bugzilla bug 1813012, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit b45e5ac into openshift:master Sep 2, 2020
@openshift-ci-robot
Copy link
Contributor

@retroflexer: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1813012 has not been moved to the MODIFIED state.

In response to this:

Bug 1813012: Remove the unused flags and images used in the previous releases for etcd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants