Bug 1984576: baremetal: reinstate provisioningInterface for provisioning CR

[hardys]

This was removed in #5015 but we should still include it if a user
provides a value - since it's now optional we'll pass an empty
string if no value is provided, which will trigger the new logic
that detects the interface name by MAC.

[hardys]

/label platform/baremetal

[hardys]

/cc @asalkeld @stbenjam

[derekhiggins]

lgtm

[hardys]

I tested with and without the optional provisioningNetworkInterface and can see the templating results in an empty string when it's not provided which I think should work fine with the related https://github.com/metal3-io/ironic-image/pull/272/files changes:

$ cat ocp/ostest/openshift/99_baremetal-provisioning-config.yaml 
apiVersion: metal3.io/v1alpha1
kind: Provisioning
metadata:
  name: provisioning-configuration
spec:
  provisioningInterface: ""

[hardys]

/retitle Bug 1984576: baremetal: reinstate provisioningInterface for provisioning CR

[openshift-ci]

@hardys: This pull request references Bugzilla bug 1984576, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

In response to this:

Bug 1984576: baremetal: reinstate provisioningInterface for provisioning CR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dtantsur]

/lgtm

[patrickdillon]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@hardys: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-openstack-kuryr	29dddd0	link	/test e2e-openstack-kuryr
ci/prow/e2e-crc	29dddd0	link	/test e2e-crc
ci/prow/e2e-libvirt	29dddd0	link	/test e2e-libvirt
ci/prow/e2e-aws-workers-rhel7	29dddd0	link	/test e2e-aws-workers-rhel7
ci/prow/e2e-metal-ipi-ovn-ipv6	29dddd0	link	/test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@hardys: All pull requests linked via external trackers have merged:

• openshift/installer#5100

Bugzilla bug 1984576 has been moved to the MODIFIED state.

In response to this:

Bug 1984576: baremetal: reinstate provisioningInterface for provisioning CR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[derekhiggins]

e2e-metal-ipi-ovn-ipv6 failed for a different reason (BMO failed to start)

{"level":"error","ts":1626958012.7065668,"logger":"setup","msg":"unable to start manager","error":"error listening on :9440: listen tcp :9440: bind: address already in use","stacktrace":"main.main\n\t/go/src/github.com/metal3-io/baremetal-operator/main.go:134\nruntime.main\n\t/usr/lib/golang/src/runtime/proc.go:225"}

Looks like the bug is fixed, static-ip-manager did its job

• /usr/sbin/ip addr add fd00:1101::3/64 dev enp1s0 valid_lft 10 preferred_lft 10

[hardys]

e2e-metal-ipi-ovn-ipv6 failed for a different reason (BMO failed to start)

{"level":"error","ts":1626958012.7065668,"logger":"setup","msg":"unable to start manager","error":"error listening on :9440: listen tcp :9440: bind: address already in use","stacktrace":"main.main\n\t/go/src/github.com/metal3-io/baremetal-operator/main.go:134\nruntime.main\n\t/usr/lib/golang/src/runtime/proc.go:225"}

Ack, that is https://bugzilla.redhat.com/show_bug.cgi?id=1983975 which I believe @andfasano is looking into

Looks like the bug is fixed, static-ip-manager did its job

• /usr/sbin/ip addr add fd00:1101::3/64 dev enp1s0 valid_lft 10 preferred_lft 10

\o/