Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Wait for expected number of drivers starting API #152

Merged
merged 1 commit into from Jun 19, 2021
Merged

Revert Wait for expected number of drivers starting API #152

merged 1 commit into from Jun 19, 2021

Conversation

dtantsur
Copy link
Member

Ironic has been fixed, the work around is no longer needed.

Reverts #134

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Feb 25, 2021
@openshift-ci-robot
Copy link

@dtantsur: This pull request references Bugzilla bug 1902653, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target the "4.8.0" release, but it targets "4.7.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (ERRATA) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Revert "Bug 1902653: Wait for expected number of drivers starting API"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 25, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2021
@dtantsur dtantsur changed the title Revert "Bug 1902653: Wait for expected number of drivers starting API" Revert "Wait for expected number of drivers starting API" Feb 25, 2021
@openshift-ci-robot openshift-ci-robot removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 25, 2021
@openshift-ci-robot
Copy link

@dtantsur: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Revert "Wait for expected number of drivers starting API"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur
Copy link
Member Author

/cc @derekhiggins @hardys

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2021
@dtantsur
Copy link
Member Author

/remove-lifecycle stale
/retest

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2021
@dtantsur
Copy link
Member Author

/retest

Something fails when cloning..

@elfosardo
Copy link

/retest

@droslean
Copy link
Member

/test e2e-metal-ipi-virtualmedia

@droslean
Copy link
Member

/retitle Revert 'Wait for expected number of drivers starting API'

@openshift-ci openshift-ci bot changed the title Revert "Wait for expected number of drivers starting API" Revert 'Wait for expected number of drivers starting API' May 27, 2021
@elfosardo elfosardo changed the title Revert 'Wait for expected number of drivers starting API' Revert Wait for expected number of drivers starting API May 27, 2021
@elfosardo
Copy link

/retest

@elfosardo
Copy link

/test e2e-metal-ipi-virtualmedia

@elfosardo
Copy link

/test prevalidation-e2e-metal-ipi-prevalidation

@droslean
Copy link
Member

/refresh
/test prevalidation-e2e-metal-ipi-prevalidation

@openshift-ci-robot
Copy link

@dtantsur: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/prevalidation-e2e-metal-ipi-prevalidation e6df0a6 link /test prevalidation-e2e-metal-ipi-prevalidation

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfosardo
Copy link

/refresh
/test prevalidation-e2e-metal-ipi-prevalidation

@dtantsur
Copy link
Member Author

/retest

@elfosardo
Copy link

/test prevalidation-e2e-metal-ipi-prevalidation

@elfosardo
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 31, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@derekhiggins
Copy link

/test prevalidation-e2e-metal-ipi-prevalidation

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4a62eff into master Jun 19, 2021
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/ironic-image that referenced this pull request Oct 25, 2022
@metal3-io-bot
Merge pull request openshift#152 from juliakreger/snponly-is-better-f…
ec6f3aa 
…or-uefi

Use snponly.efi instead of ipxe.efi for IPv4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann Awaiting requested review from dhellmann

@juliakreger juliakreger Awaiting requested review from juliakreger

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@hardys hardys Awaiting requested review from hardys

Assignees

@elfosardo elfosardo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dtantsur @openshift-ci-robot @openshift-bot @elfosardo @droslean @derekhiggins @openshift-merge-robot