Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packages to pick up latest changes #156

Merged
merged 1 commit into from Mar 23, 2021
Merged

Update packages to pick up latest changes #156

merged 1 commit into from Mar 23, 2021

Conversation

elfosardo
Copy link

Sync ironic, ironic-lib and sushy with latest needed changes.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2021
@dtantsur
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@elfosardo
Copy link
Author

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

21 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@hardys
Copy link

hardys commented Mar 19, 2021

/hold

This is repeatedly failing, lets hold until it's either fixed or expected to work

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2021
@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-prevalidation

2 similar comments
@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-prevalidation

@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-prevalidation

@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-prevalidation

@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@elfosardo
Copy link
Author

the failure may be related to the latest RBAC changes in ironic, maybe a bug there or an issue with oslo policy:
. Either ensure your deployment is ready for the new default or copy/paste the deprecated policy into your policy file and maintain it manually. warnings.warn(deprecated_msg) 2021-03-22 10:19:02.489 42 ERROR oslo_policy._parser [req-176be080-f1ab-461c-834d-c0d87bb374e1 - - - - -] Failed to understand rule or rule:public_api: ValueError: Could not parse rule 2021-03-22 10:19:02.489 42 ERROR oslo_policy._parser Traceback (most recent call last): 2021-03-22 10:19:02.489 42 ERROR oslo_policy._parser File "/usr/lib/python3.6/site-packages/oslo_policy/_parser.py", line 340, in _parse_text_rule 2021-03-22 10:19:02.489 42 ERROR oslo_policy._parser return state.result 2021-03-22 10:19:02.489 42 ERROR oslo_policy._parser File "/usr/lib/python3.6/site-packages/oslo_policy/_parser.py", line 141, in result 2021-03-22 10:19:02.489 42 ERROR oslo_policy._parser raise ValueError('Could not parse rule') 2021-03-22 10:19:02.489 42 ERROR oslo_policy._parser ValueError: Could not parse rule 2021-03-22 10:19:02.489 42 ERROR oslo_policy._parser ESC[00m /usr/lib/python3.6/site-packages/oslo_policy/policy.py:707: UserWarning: Policy "baremetal:node:ipa_heartbeat":"rule:public_api" was deprecated in W in favor of "baremetal:node:ipa_heartbeat":"". Reason: The baremetal utility API is now aware of system scope and default

@elfosardo
Copy link
Author

for some reason we're installing a very old version of oslo-policy and likely other libs
this will be fixed with new packages when available

@elfosardo
Update packages to pick up latest changes
dde85d8 
Sync ironic, ironic-lib and sushy with latest needed changes.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2021
@elfosardo
Copy link
Author

/test prevalidation-images

@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-prevalidation

@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@elfosardo
Copy link
Author

looks good to go now, syncing prod repos before running CI again

@elfosardo
Copy link
Author

/test images

1 similar comment
@elfosardo
Copy link
Author

/test images

@elfosardo
Copy link
Author

/test e2e-metal-ipi

@elfosardo
Copy link
Author

/test e2e-metal-ipi-virtualmedia

@elfosardo
Copy link
Author

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2021
dtantsur
dtantsur approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

main-packages-list.txt
parted
psmisc
python3-debtcollector >= 2.2.0-0.20201008171245.649189d.el8
python3-dracclient
python3-gunicorn
python3-ironic-lib >= 4.4.1-0.20201218041209.aa7cfec.el8
python3-ironic-lib >= 4.5.1-0.20210227011240.e7a35e4.el8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is rather old, I suspect we'll need another update soon.

Copy link
Author

@elfosardo elfosardo Mar 24, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we chose to enable this version for the time being because it was the last one before the wallaby cut
now that we have the repos correctly set, we're going to increase the version to 4.6.1

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elfosardo
Copy link
Author

/test e2e-metal-ipi-virtualmedia

@openshift-merge-robot openshift-merge-robot merged commit 571865a into openshift:master Mar 23, 2021
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/ironic-image that referenced this pull request Oct 25, 2022
@metal3-io-bot
Merge pull request openshift#156 from Nordix/fix-ip-mael
c3a0bf4 
Fix the IP address parsing in ironic-common.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur dtantsur approved these changes

@juliakreger juliakreger Awaiting requested review from juliakreger

Assignees

@dtantsur dtantsur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@elfosardo @dtantsur @openshift-bot @hardys @openshift-ci-robot @openshift-merge-robot