Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable irmc bios interface #191

Merged
merged 3 commits into from Jul 23, 2021
Merged

Conversation

hs0210
Copy link

@hs0210 hs0210 commented Jul 13, 2021

I will pick up the upstream PRs after that has been merged, and will add that commits into this one.
URL of upstream PRs are as follows.

Therefore, please pend the review of this PR.

Signed-off-by: Hu Shuai hus.fnst@cn.fujitsu.com

@openshift-ci openshift-ci bot requested review from hardys and zaneb July 13, 2021 10:16
@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2021

Hi @hs0210. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 13, 2021
@elfosardo
Copy link

I think we should also wait for #190 to avoid more conflicts/rebase

@hs0210
Copy link
Author

hs0210 commented Jul 14, 2021

@elfosardo Thanks, done.

@dtantsur
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 19, 2021
@hs0210
Copy link
Author

hs0210 commented Jul 19, 2021

/retest

@dtantsur
Copy link
Member

/hold

We should wait until metal3-io#286 merges or at least is ready to review and passes the CI.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2021
Copy link

@elfosardo elfosardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hs0210 my understanding is that this works if python-scciclient is at least version 0.10.0, as specified in the upstream change metal3-io#286
you need to update the main-packages file to reflect that

@hs0210
Copy link
Author

hs0210 commented Jul 20, 2021

@elfosardo Done.

Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>
@elfosardo
Copy link

@hs0210 thanks, the failure at this moment is normal, we need to add the package
I'll take care of retesting this once the pkg is in the correct repo

@elfosardo
Copy link

@hs0210 had to change version to the correct one as we track directly master

@hase1128
Copy link

@elfosardo

I'll take care of retesting this once the pkg is in the correct repo

Thank you.
I don't know how to check the status of pkg and repository of python-scciclient, but if the latest rpm(0.10.0) is put in the repo, I think that rpm will be used. Could you please check the pkg in the repo?

@elfosardo
Copy link

@hase1128 the version that I specified includes the required change

@elfosardo
Copy link

/test prevalidation-images

2 similar comments
@elfosardo
Copy link

/test prevalidation-images

@elfosardo
Copy link

/test prevalidation-images

@elfosardo
Copy link

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@elfosardo
Copy link

/test prevalidation-e2e-metal-ipi-prevalidation

@elfosardo
Copy link

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@hase1128
Copy link

@elfosardo, @rhjanders

Regarding CI error, does this mean we still can't get the correct pkg(0.9.1-0.20210720102209.34ccd96.el8)?


Error: Failed to download metadata for repo 'localdev-rhel-8-server-ose-rpms': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried
Ignoring repositories: localdev-openstack-16-for-rhel-8-rpms, localdev-rhel-8-appstream-rpms, localdev-rhel-8-baseos-rpms, localdev-rhel-8-codeready-builder-rpms, localdev-rhel-8-fast-datapath-rpms, localdev-rhel-8-rt-rpms, localdev-rhel-8-server-ansible-2.9-rpms, localdev-rhel-8-server-ose-rpms
Last metadata expiration check: 0:00:19 ago on Tue Jul 20 12:43:17 2021.
No match for argument: python3-scciclient >= 0.9.1-0.20210720102209.34ccd96.el8
Error: Unable to find a match: python3-scciclient >= 0.9.1-0.20210720102209.34ccd96.el8

@rhjanders
Copy link

@hase1128 this looks more like a repo server issue (possibly due to metadata being re-generated while the job ran). Let me see if I can rerun the tests.

@rhjanders
Copy link

/retest

@rhjanders
Copy link

/retest

1 similar comment
@rhjanders
Copy link

/retest

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@rhjanders
Copy link

/retest

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@hs0210
Copy link
Author

hs0210 commented Jul 23, 2021

/retest

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@rhjanders
Copy link

/retest

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@rhjanders
Copy link

/retest

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@elfosardo
Copy link

/retest

@elfosardo
Copy link

I triggered the prevalidation jobs again although they're failing because some new packages have been tagged in the prevalidation repositories and they're missing correct dependencies. This won't influence production and the failure is not due to this PR, the main CI jobs are passing correctly.
To avoid delaying further this PR, I'm going to bypass the failing prevalidation jobs and merge the change.

@elfosardo
Copy link

/override ci/prow/prevalidation-e2e-metal-ipi-prevalidation

@openshift-ci
Copy link

openshift-ci bot commented Jul 23, 2021

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/prevalidation-e2e-metal-ipi-prevalidation

In response to this:

/override ci/prow/prevalidation-e2e-metal-ipi-prevalidation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elfosardo
Copy link

/override ci/prow/prevalidation-e2e-metal-ipi-prevalidation

1 similar comment
@elfosardo
Copy link

/override ci/prow/prevalidation-e2e-metal-ipi-prevalidation

@openshift-ci
Copy link

openshift-ci bot commented Jul 23, 2021

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/prevalidation-e2e-metal-ipi-prevalidation

In response to this:

/override ci/prow/prevalidation-e2e-metal-ipi-prevalidation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elfosardo
Copy link

/override ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@openshift-ci
Copy link

openshift-ci bot commented Jul 23, 2021

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/prevalidation-e2e-metal-ipi-prevalidation

In response to this:

/override ci/prow/prevalidation-e2e-metal-ipi-prevalidation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 289f10d into openshift:master Jul 23, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 23, 2021

@elfosardo: Overrode contexts on behalf of elfosardo: ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

In response to this:

/override ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/ironic-image that referenced this pull request Oct 25, 2022
…d-raid-interfaces

enable idrac-wsman RAID and BIOS interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants