Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom deploy: do not require an ISO #193

Merged
merged 2 commits into from Jul 16, 2021

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Jul 15, 2021

It is possible to only use PXE artefacts, in which case we need to
generate an ignition file, but don't need to customize the ISO.

Increase verbosity of configure-coreos-ipa for debugging.

@openshift-ci openshift-ci bot requested review from dhellmann and hardys July 15, 2021 16:11
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2021
@dhellmann
Copy link

/uncc

It is possible to only use PXE artefacts, in which case we need to
generate an ignition file, but don't need to customize the ISO.
@dtantsur
Copy link
Member Author

/cc @kirankt

@openshift-ci openshift-ci bot requested a review from kirankt July 15, 2021 16:26
Copy link

@kirankt kirankt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, kirankt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elfosardo
Copy link

elfosardo commented Jul 16, 2021

/hold need pkgs update first #192

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2021
@elfosardo
Copy link

elfosardo commented Jul 16, 2021

/test e2e-metal-ipi

@elfosardo
Copy link

/test e2e-metal-ipi-virtualmedia

@elfosardo
Copy link

/test e2e-metal-ipi

@elfosardo
Copy link

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2021
@kirankt
Copy link

kirankt commented Jul 16, 2021

/test e2e-metal-ipi-virtualmedia

@openshift-merge-robot openshift-merge-robot merged commit 8adadcf into openshift:master Jul 16, 2021
openshift-merge-robot pushed a commit that referenced this pull request Jul 22, 2021
Add support for noop management and manual-management
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants