Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inspector callback_endpoint_override #197

Merged
merged 1 commit into from Jul 26, 2021
Merged

Add inspector callback_endpoint_override #197

merged 1 commit into from Jul 26, 2021

Conversation

imain
Copy link

@imain imain commented Jul 21, 2021

In order for IPA to call back into ironic inspector when being
used on external networks, we'll need to set this as well.

@imain
Add inspector callback_endpoint_override
f5c03c6 
In order for IPA to call back into ironic inspector when being
used on external networks, we'll need to set this as well.
@dtantsur
Copy link
Member

The change looks good, but I wonder why it fails the CI.

@elfosardo
Copy link

/retest

@zaneb
Copy link
Member

zaneb commented Jul 22, 2021

Change looks fine but why is this not upstream?

@zaneb
Copy link
Member

zaneb commented Jul 23, 2021

I opened metal3-io#287 for upstream.
/lgtm
/retest

@openshift-ci
Copy link

openshift-ci bot commented Jul 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imain, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 23, 2021
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@elfosardo
Copy link

/retest

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Jul 26, 2021

@imain: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/prevalidation-e2e-metal-ipi-prevalidation f5c03c6 link /test prevalidation-e2e-metal-ipi-prevalidation
ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation f5c03c6 link /test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfosardo elfosardo merged commit 7694a8a into openshift:master Jul 26, 2021
@elfosardo
Copy link

prevalidation jobs are not required for this change, they should not be here
need to check why they were triggered anyway
the regular CI is passing, so I merged the PR

openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/ironic-image that referenced this pull request Oct 25, 2022
@metal3-io-bot
Merge pull request openshift#197 from Nordix/fix-dnsmasq-mael
c70e555 
add dhcp-sequential-ip to dnsmasq config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees

@zaneb zaneb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@imain @dtantsur @elfosardo @zaneb @openshift-bot