Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename packages list #208

Merged

Conversation

elfosardo
Copy link

Use .ocp extension to be explicit on the purpose

@openshift-ci openshift-ci bot requested review from dtantsur and hardys August 20, 2021 09:14
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2021
@dtantsur
Copy link
Member

Why are you doing this? This change adds an unnecessary divergence from upstream.

@elfosardo
Copy link
Author

Why are you doing this? This change adds an unnecessary divergence from upstream.

I'm doing it exactly because of that, to indicate that this is different from upstream

@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-prevalidation

@dtantsur
Copy link
Member

Let's maybe split common (unversioned) dependencies and OpenStack dependencies? I suspect only the latter will differ for OKD.

@elfosardo
Copy link
Author

Let's maybe split common (unversioned) dependencies and OpenStack dependencies? I suspect only the latter will differ for OKD.

To do that we would probably have to change the logic in prepare-image.sh first, now it assumes we only have 1 list of packages to install (or 2 if we specify EXTRA_PKGS_LIST as ARG)
One more thing that potentially could not be in favor of the split is if we find ourselves in a situation where we need a specific non openstack package (could be for a security fix, for example) and the names/versions differ from one distribution to another.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2021
Use .ocp extension to be explicit on the purpose
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2021
@elfosardo
Copy link
Author

/test e2e-metal-ipi

@elfosardo
Copy link
Author

/test e2e-metal-ipi-virtualmedia

@elfosardo
Copy link
Author

/retest

@iurygregory
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie, elfosardo, iurygregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bfournie,elfosardo,iurygregory]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 18ea571 into openshift:master Sep 22, 2021
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/ironic-image that referenced this pull request Oct 25, 2022
Merge RUN commands to reduce layers number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants