New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename packages list #208
Rename packages list #208
Conversation
Why are you doing this? This change adds an unnecessary divergence from upstream. |
I'm doing it exactly because of that, to indicate that this is different from upstream |
/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation |
/test prevalidation-e2e-metal-ipi-prevalidation |
Let's maybe split common (unversioned) dependencies and OpenStack dependencies? I suspect only the latter will differ for OKD. |
To do that we would probably have to change the logic in prepare-image.sh first, now it assumes we only have 1 list of packages to install (or 2 if we specify EXTRA_PKGS_LIST as ARG) |
Use .ocp extension to be explicit on the purpose
cb61f18
to
a5ebc78
Compare
/test e2e-metal-ipi |
/test e2e-metal-ipi-virtualmedia |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie, elfosardo, iurygregory The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merge RUN commands to reduce layers number
Use .ocp extension to be explicit on the purpose