Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync metal3-io master #215

Merged

Conversation

elfosardo
Copy link

No description provided.

namnx228 and others added 30 commits June 21, 2021 15:06
Update the inspector endpoint to port 5049 when using the reverse proxy
The root cause has been fixed in Ironic.

This reverts commit 3c8acf4.
Tokens are mandatory in Ironic and enabled by default for a while.
This change adds a flag that disables installing documentation from
RPMs. Additionally, prevent installing weak dependencies globally.
Revert "Wait for expected number of drivers starting API"
Prevent installing docs via a DNF flag
[Trivial] Remove no-op require_agent_token
We only enable vendor interfaces for a subset of hardware types, there
is not reason for that. The Redfish vendor interface, for example,
contains a call to eject virtual CD, which we may use in the future.
Enable missing vendor interfaces
Bump sushy-tools version to 0.17.0 to pick up BIOS attribute registry support for testing.
Signed-off-by: Zou Yu <zouy.fnst@cn.fujitsu.com>
In order for IPA to call back into ironic inspector when being
used on external networks, we'll need to set this as well.
The upstream openstack tripleo team decided to move the `tripleo_repos` folder under `plugins/module_utils/` openstack-archive/tripleo-repos@77dc579
Due to this, when building the ironic container, we end us with a `404 Not Found` error.
Updating the script as per as the new upstream repo structure.
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
Currently it only waits for files in the first created directory because
of an infinite loop inside the "for" loop.
Add inspector callback_endpoint_override
Introduce an ARG BASE_IMAGE that allows customizing the base image used
to build the container.
This can be useful for quickly changing base image for testing,
especially in automated setups.
During virtualmedia deploy the port in the iso url is missing causing
the deploy to fail.

For more info please see https://bugzilla.redhat.com/show_bug.cgi?id=1990316
iurygregory and others added 6 commits September 14, 2021 09:49
This commit bumps the version of sushy-tools to 0.18.0, this is the
latest release that includes new features.
Remove the trailing slash from the heartbeat rule
Update sushy-tools to 0.18.1 with an authentication fix
@openshift-ci openshift-ci bot requested a review from zaneb September 24, 2021 08:07
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2021
@elfosardo
Copy link
Author

/retest

@derekhiggins
Copy link

ironic-conductor can't start, iirc ibmc is upstream only

2021-09-24 11:29:09.962 1 ERROR oslo_service.service ironic.common.exception.DriverLoadError: Driver, hardware type or interface ibmc could not be loaded. Reason: Unable to import the python-ibmcclient library.

@iurygregory
Copy link

ironic-conductor can't start, iirc ibmc is upstream only

2021-09-24 11:29:09.962 1 ERROR oslo_service.service ironic.common.exception.DriverLoadError: Driver, hardware type or interface ibmc could not be loaded. Reason: Unable to import the python-ibmcclient library.

Yeah I agree with Derek, we don't support this driver downstream.

@elfosardo elfosardo force-pushed the upstream-downstream-20210924 branch 2 times, most recently from 51ffb79 to b951735 Compare September 24, 2021 22:46
@iurygregory
Copy link

/test e2e-metal-ipi-virtualmedia

@dtantsur
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c7b0735 into openshift:master Sep 27, 2021
@@ -43,6 +43,7 @@ python3-packaging >= 20.4-1.el8ost
python3-paste >= 3.2.4-1.el8ost
python3-paste-deploy >= 2.0.1-4.el8ost
python3-pint >= 0.10.1-1.el8ost
python3-proliantutils
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should have been added to the OKD pkgs list as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ we really need an okd job so that we stop doing this mistake

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d'oh! sorry, you're right :/

@elfosardo elfosardo mentioned this pull request Sep 27, 2021
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/ironic-image that referenced this pull request Oct 25, 2022
Correct the destination grub path when building an ESP image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet