Merge metal3 20211102 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ip` command returns the short-form of the IPv6 address so that is what should be used for comparison, even if the user entered an IPv6 address in long-form for PROVISIONING_IP. Use `ipcalc` to get the short-form address. This command can also be used for IPv4 as it strips out the subnet mask for IPv4 and IPv6. For the PROVISIONING_IPs below, this is what would be set for IRONIC_IP: fd8a:aaaa:00bb:c1df::3 -> fd8a:aaaa:bb:c1df::3 fd8a:aaaa:00bb:c1df:0000:0000:0000:0003 -> fd8a:aaaa:bb:c1df::3 fd8a:aaaa:00bb:c1df::3/64 -> fd8a:aaaa:bb:c1df::3 fd8a:aaaa:00bb:c1df::3/128 -> fd8a:aaaa:bb:c1df::3 10.10.10.1 -> 10.10.10.1 10.10.10.1/24 -> 10.10.10.1 10.10.10.1/64 ->
Compare IPs using the short form of IPv6 address
This commit enables code included in the following changes: https://review.opendev.org/c/openstack/ironic/+/800001 https://review.opendev.org/c/openstack/ironic/+/804032 This is done by configuring a non-zero priority for clear_job_queue verify step.
Enable Lifecycle Controller job queue clear by default
✨ Update CI status badges
Run redfish-emulator in debug mode
Adds a new entrypoint /bin/configure-coreos-ipa to be run as an init container after the images are downloaded.
It is possible to only use PXE artefacts, in which case we need to generate an ignition file, but don't need to customize the ISO.
This is no longer needed since openshift/cluster-baremetal-operator#202, which passes the proper OpenShift image to the configure-coreos-ipa script.
So we can e.g override IGNITION_FILE when running this container standalone for metal3 upstream testing where this container isn't included in the metal3 pod by default.
Add configure-coreos-ipa script
All these are related to the iscsi deploy which we don't use (and which no longer exists).
Remove unused dependencies
elfosardo
requested review from
dtantsur,
bfournie,
hardys,
iurygregory and
derekhiggins
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
/lgtm |
e-minguez
pushed a commit
to e-minguez/ironic-image
that referenced
this pull request
Feb 23, 2022
Run ironic-api as WSGI when standalone with TLS capability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.