New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install specific version of scciclient #235
Install specific version of scciclient #235
Conversation
/test prevalidation-e2e-metal-ipi-prevalidation |
/retest |
/test images |
/hold |
We need a specific version of scciclient that includes the commit [1] [1] https://opendev.org/x/python-scciclient/commit/34ccd96c1262e1268a4101bc6e40f8a647f497c2
bd592c0
to
1f7fb56
Compare
/retest |
/unhold |
@@ -47,7 +47,7 @@ python3-paste-deploy >= 2.0.1-4.el8ost | |||
python3-pint >= 0.10.1-1.el8ost | |||
python3-proliantutils >= 2.12.0-0.20211012162915.abc6432.el8 | |||
python3-pyghmi >= 1.5.14-2.1.el8ost | |||
python3-scciclient >= 0.9.1-0.20210827164043.21a184b.el8 | |||
python3-scciclient = 0.10.0-0.20211117144100.22064a9.el8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason to swap from ">=" to "="?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change has been done to avoid an unpleasant situation where an older version was installed from the OSP repo
that's why we're pinning a specific version now, and we're probably going to do the same for other ironic related packages too, at least until we complete the removal of OSP repo dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know =)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo, iurygregory The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Prevent unbound variable error in prepare-image
We need a specific version of scciclient that includes the commit [1]
[1] https://opendev.org/x/python-scciclient/commit/34ccd96c1262e1268a4101bc6e40f8a647f497c2
Fix #234