Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install specific version of scciclient #235

Merged

Conversation

elfosardo
Copy link

We need a specific version of scciclient that includes the commit [1]

[1] https://opendev.org/x/python-scciclient/commit/34ccd96c1262e1268a4101bc6e40f8a647f497c2

Fix #234

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2021
@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-prevalidation

@elfosardo
Copy link
Author

/retest

@elfosardo
Copy link
Author

/test images

@elfosardo
Copy link
Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2021
@elfosardo
Copy link
Author

/retest

@elfosardo
Copy link
Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2021
@@ -47,7 +47,7 @@ python3-paste-deploy >= 2.0.1-4.el8ost
python3-pint >= 0.10.1-1.el8ost
python3-proliantutils >= 2.12.0-0.20211012162915.abc6432.el8
python3-pyghmi >= 1.5.14-2.1.el8ost
python3-scciclient >= 0.9.1-0.20210827164043.21a184b.el8
python3-scciclient = 0.10.0-0.20211117144100.22064a9.el8

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason to swap from ">=" to "="?

Copy link
Author

@elfosardo elfosardo Nov 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change has been done to avoid an unpleasant situation where an older version was installed from the OSP repo
that's why we're pinning a specific version now, and we're probably going to do the same for other ironic related packages too, at least until we complete the removal of OSP repo dependency

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know =)

@iurygregory iurygregory added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, iurygregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [elfosardo,iurygregory]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 027b002 into openshift:master Nov 18, 2021
e-minguez pushed a commit to e-minguez/ironic-image that referenced this pull request Feb 23, 2022
Prevent unbound variable error in prepare-image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OCP4.10] Old scciclient is unexpectedly used which causes bootstrap error on iRMC IPI
4 participants