Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring Ironic version to 18.3.0-0.20211206200515.0ff3da2 #240

Merged
merged 1 commit into from Dec 8, 2021

Conversation

rhjanders
Copy link

@rhjanders rhjanders commented Dec 7, 2021

This commit pulls in the latest ironic-master into OpenShift,
bringing a number of bugfixes and enhancements.

This commit brings in the upstream OpenStack/Ironic fix which
resolves an issue where overly strict validation prevents using
port 443 for iRMC communications:

https://review.opendev.org/c/openstack/ironic/+/817154
@elfosardo
Copy link

/approve

@elfosardo
Copy link

after talking with Jacob, we've decided to try and get this merged before next upstream releases are ready

@elfosardo
Copy link

/cc @dtantsur @bfournie @derekhiggins

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2021
@openshift-ci
Copy link

openshift-ci bot commented Dec 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, rhjanders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhjanders
Copy link
Author

/test prevalidation-images

@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-prevalidation

@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

2 similar comments
@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@elfosardo
Copy link

tagged in production, waiting for the sync

@rhjanders
Copy link
Author

/test images

@rhjanders
Copy link
Author

/test e2e-metal-ipi

@rhjanders
Copy link
Author

/test e2e-metal-ipi-virtualmedia

@rhjanders rhjanders changed the title Convert the type of irmc_port to int Bring Ironic version to 18.3.0-0.20211206200515.0ff3da2 Dec 8, 2021
@rhjanders
Copy link
Author

Changed the title and description to better reflect the current course of action. While this PR was originally opened to incorporate https://review.opendev.org/c/openstack/ironic/+/817154 in ironic-image for our Fujitsu colleagues, we ended up syncing all the latest changes to Ironic master into openshift/ironic-image.

@dtantsur
Copy link
Member

dtantsur commented Dec 8, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2021
@openshift-merge-robot openshift-merge-robot merged commit 08e4acd into openshift:master Dec 8, 2021
@rhjanders rhjanders deleted the change-817154 branch December 8, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants