Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use OSP repo in image build #249

Closed
wants to merge 1 commit into from
Closed

Do not use OSP repo in image build #249

wants to merge 1 commit into from

Conversation

elfosardo
Copy link

No description provided.

@elfosardo
Copy link
Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2022
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2022
@elfosardo
Copy link
Author

/test images

@elfosardo
Copy link
Author

/test images
/test prevalidation-images

@elfosardo
Copy link
Author

/test images
/test prevalidation-images

@elfosardo
Copy link
Author

/test e2e-metal-ipi

@elfosardo
Copy link
Author

/test images

2 similar comments
@elfosardo
Copy link
Author

/test images

@elfosardo
Copy link
Author

/test images

e-minguez pushed a commit to e-minguez/ironic-image that referenced this pull request Feb 23, 2022
@metal3-io-bot
Merge pull request openshift#249 from elfosardo/split-ironic-conf
255174b 
Move ironic specific config to ironic Dockerfile
@elfosardo
Copy link
Author

/test prevalidation-images

7 similar comments
@elfosardo
Copy link
Author

/test prevalidation-images

@elfosardo
Copy link
Author

/test prevalidation-images

@elfosardo
Copy link
Author

/test prevalidation-images

@elfosardo
Copy link
Author

/test prevalidation-images

@elfosardo
Copy link
Author

/test prevalidation-images

@elfosardo
Copy link
Author

/test prevalidation-images

@elfosardo
Copy link
Author

/test prevalidation-images

@elfosardo
Copy link
Author

/retest

1 similar comment
@elfosardo
Copy link
Author

/retest

@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-prevalidation

@elfosardo elfosardo changed the title [DNM] Test build with no osp repo Do not use OSP repo in image build Mar 10, 2022
@elfosardo
Copy link
Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2022
@elfosardo
Do not use OSP repo to build image
60190d5 
We need newer packages and to avoid conflicts we do not use the OSP 16
repo if present.
@elfosardo
Copy link
Author

/cc @dtantsur @iurygregory @bfournie @lhh

@elfosardo
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@openshift-ci
Copy link

openshift-ci bot commented Mar 10, 2022

@elfosardo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi 60190d5 link true /test e2e-metal-ipi
ci/prow/images 60190d5 link true /test images
ci/prow/e2e-metal-ipi-virtualmedia 60190d5 link true /test e2e-metal-ipi-virtualmedia

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Mar 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, lhh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elfosardo
Copy link
Author

/hold
we need the new ironic repo first

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2022
@elfosardo
Copy link
Author

we'll change this in the config of the image itself

@elfosardo elfosardo closed this Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhh lhh lhh approved these changes

@bfournie bfournie Awaiting requested review from bfournie

@dtantsur dtantsur Awaiting requested review from dtantsur

@iurygregory iurygregory Awaiting requested review from iurygregory

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elfosardo @lhh