New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge metal3-io up to mariadb removal #250
Merge metal3-io up to mariadb removal #250
Conversation
For whateve reason, Python itself depends on it in CentOS.
This is the preferred mode for the combined Ironic process.
Do not remove pip in the source build
This path is where the cache is maintained, and Ironic cleans it up periodically. Keeping it in /shared/tftpboot means that Ironic may remove files from it.
Move tftp_master_path to a subdirectory (fixes metal3-io#333)
* ipxe_enabled no longer exists * pxe_append_params -> kernel_append_params * (uefi_)pxe_config_template not used for iPXE
Clean up deprecated and unnecessary PXE configuration
Add a combined Ironic launcher
Make Ironic generate a boot.ipxe
Remove unnecessary flag of ipcalc
This new feature provides a history of all events for a node. We don't use it, and it creates an additional load on the database. Disable.
Use IPv6-friendly URLs for CoreOS
Disable the node history feature
The fall-back to [pxe] is deprecated. See also: openshift/installer#5504
Install the RPM of the combined Ironic
Set [irmc]kernel_append_params explicitly
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1) The authentication code assumes /v1 prefix, but Ironic has redirects, e.g. /drivers -> /v1/drivers 2) The lookup/heartbeat endpoint rules are overridden by the generic rule, so they don't have effect. While here, fix some whitespace.
When Ironic is in reverse proxy mode, it is also used by runhttpd.
Otherwise it will use the private URL when building paths in responses.
/test e2e-metal-ipi-virtualmedia |
1) It blocks /v1/introspection/ but allows /v1/introspection, which lists introspection results per node. 2) It does not block /v1/rules used to create introspection rules.
/test e2e-metal-ipi |
/retest |
2 similar comments
/retest |
/retest |
/hold cancel There is no point in prevalidation jobs here: this change does not actually tag new packages. |
@dtantsur: /override requires a failed status context or a job name to operate on.
Only the following contexts were expected:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation |
/hold |
@dtantsur: Overrode contexts on behalf of dtantsur: ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dtantsur: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/unhold |
Remove the docker entrypoint as it does not exist
Also a few later patches: