Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge metal3-io up to mariadb removal #250

Merged
merged 32 commits into from Jan 31, 2022

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Jan 11, 2022

  • Make Ironic generate a boot.ipxe
  • Do not remove pip in the source build
  • Add a combined Ironic launcher
  • Allow reverse proxy setup for Ironic
  • Disable synchronous mode in sqlite
  • Use create_schema for sqlite
  • Move tftp_master_path to a subdirectory
  • Clean up deprecated and unnecessary PXE configuration
  • Remove unnecessary flag of ipcalc
  • Disable the node history feature
  • Use IPv6-friendly URLs for CoreOS
  • Install the RPM of the combined Ironic
  • Set [irmc]kernel_append_params explicitly

Also a few later patches:

  • Add different variables for htpasswd of ironic and inspector
  • Fix authentication with Ironic reverse proxy
  • Move LISTEN_ALL_INTERFACES to ironic-common
  • Make private proxied ports configurable
  • Tell Ironic the correct public endpoint
  • Fix authentication for inspector in reverse proxy mode

dtantsur and others added 25 commits December 7, 2021 16:01
For whateve reason, Python itself depends on it in CentOS.
This is the preferred mode for the combined Ironic process.
Do not remove pip in the source build
This path is where the cache is maintained, and Ironic cleans it up
periodically. Keeping it in /shared/tftpboot means that Ironic may
remove files from it.
Move tftp_master_path to a subdirectory (fixes metal3-io#333)
* ipxe_enabled no longer exists
* pxe_append_params -> kernel_append_params
* (uefi_)pxe_config_template not used for iPXE
Clean up deprecated and unnecessary PXE configuration
This new feature provides a history of all events for a node. We don't
use it, and it creates an additional load on the database. Disable.
Use IPv6-friendly URLs for CoreOS
The fall-back to [pxe] is deprecated.

See also: openshift/installer#5504
Install the RPM of the combined Ironic
Set [irmc]kernel_append_params explicitly
@openshift-ci
Copy link

openshift-ci bot commented Jan 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2022
@elfosardo elfosardo self-requested a review January 11, 2022 13:52
1) The authentication code assumes /v1 prefix, but Ironic has redirects,
   e.g. /drivers -> /v1/drivers
2) The lookup/heartbeat endpoint rules are overridden by the generic
   rule, so they don't have effect.

While here, fix some whitespace.
When Ironic is in reverse proxy mode, it is also used by runhttpd.
Otherwise it will use the private URL when building paths in responses.
@dtantsur
Copy link
Member Author

/test e2e-metal-ipi-virtualmedia

1) It blocks /v1/introspection/ but allows /v1/introspection, which
   lists introspection results per node.
2) It does not block /v1/rules used to create introspection rules.
@dtantsur
Copy link
Member Author

/test e2e-metal-ipi

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2022
@dtantsur
Copy link
Member Author

/retest

2 similar comments
@dtantsur
Copy link
Member Author

/retest

@dtantsur
Copy link
Member Author

/retest

@dtantsur
Copy link
Member Author

/hold cancel
/override prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

There is no point in prevalidation jobs here: this change does not actually tag new packages.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 31, 2022

@dtantsur: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

  • prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

Only the following contexts were expected:

  • ci/prow/e2e-metal-ipi
  • ci/prow/e2e-metal-ipi-virtualmedia
  • ci/prow/images
  • ci/prow/okd-images
  • ci/prow/prevalidation-e2e-metal-ipi-prevalidation
  • ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation
  • ci/prow/prevalidation-images
  • pull-ci-openshift-ironic-image-master-e2e-metal-ipi
  • pull-ci-openshift-ironic-image-master-e2e-metal-ipi-virtualmedia
  • pull-ci-openshift-ironic-image-master-images
  • pull-ci-openshift-ironic-image-master-okd-images
  • pull-ci-openshift-ironic-image-master-prevalidation-e2e-metal-ipi-prevalidation
  • pull-ci-openshift-ironic-image-master-prevalidation-e2e-metal-ipi-virtualmedia-prevalidation
  • pull-ci-openshift-ironic-image-master-prevalidation-images
  • tide

In response to this:

/hold cancel
/override prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

There is no point in prevalidation jobs here: this change does not actually tag new packages.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur
Copy link
Member Author

/override ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@elfosardo
Copy link

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 31, 2022

@dtantsur: Overrode contexts on behalf of dtantsur: ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

In response to this:

/override ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 31, 2022

@dtantsur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfosardo
Copy link

/unhold
/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2022
@openshift-merge-robot openshift-merge-robot merged commit f9f8dbb into openshift:master Jan 31, 2022
@dtantsur dtantsur deleted the oc-allinone branch January 31, 2022 10:00
e-minguez pushed a commit to e-minguez/ironic-image that referenced this pull request Feb 23, 2022
Remove the docker entrypoint as it does not exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants