Add coreos.live.rootfs_url boot parameter

[bn222]

Add missing parameter to allow fetching the root filesystem during boot.
The boot argument relies on IRONIC_IP and HTTP_PORT being set properly.

Signed-off-by: Balazs Nemeth bnemeth@redhat.com

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bn222
To complete the pull request process, please assign zaneb after the PR has been reviewed.
You can assign the PR to them by writing /assign @zaneb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@bn222: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-virtualmedia	233064e	link	true	/test e2e-metal-ipi-virtualmedia
ci/prow/images	233064e	link	true	/test images
ci/prow/e2e-metal-ipi	233064e	link	true	/test e2e-metal-ipi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dtantsur]

/cc @zaneb

This does not look correct. The rootfs_url is added to IRONIC_KERNEL_PARAMS in scripts/coreos-ipa-common.sh.

[zaneb]

Yeah, this is wrong, or at least unnecessary. Also, it won't work with IPv6. The correct value is set here: https://github.com/openshift/ironic-image/blob/master/scripts/coreos-ipa-common.sh#L8

You didn't say what the issue was, but I suspect the root cause can be resolved by openshift/installer#5541
Also, it appears that we only fall back to using inspector.ipxe when there is something wrong with the driver: openshift/installer#5541 (comment). It's there more for auto-discovering hosts, which we don't really do.

/close

[openshift-ci]

@zaneb: Closed this PR.

In response to this:

Yeah, this is wrong, or at least unnecessary. Also, it won't work with IPv6. The correct value is set here: https://github.com/openshift/ironic-image/blob/master/scripts/coreos-ipa-common.sh#L8

You didn't say what the issue was, but I suspect the root cause can be resolved by openshift/installer#5541
Also, it appears that we only fall back to using inspector.ipxe when there is something wrong with the driver: openshift/installer#5541 (comment). It's there more for auto-discovering hosts, which we don't really do.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.