Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize jinja templates #262

Closed
wants to merge 1 commit into from
Closed

Standardize jinja templates #262

wants to merge 1 commit into from

Conversation

elfosardo
Copy link

Also remove sed command and use defined environment variables.

metal3-io change metal3-io#367

@elfosardo
Standardize jinja templates
7047da1 
Also remove sed command and use defined environment variables.
@elfosardo
Copy link
Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2022
@elfosardo
Copy link
Author

/retest

1 similar comment
@elfosardo
Copy link
Author

/retest

@elfosardo elfosardo mentioned this pull request Mar 31, 2022
Closed
@elfosardo
Copy link
Author

/retest

7 similar comments
@elfosardo
Copy link
Author

/retest

@elfosardo
Copy link
Author

/retest

@elfosardo
Copy link
Author

/retest

@elfosardo
Copy link
Author

/retest

@elfosardo
Copy link
Author

/retest

@elfosardo
Copy link
Author

/retest

@elfosardo
Copy link
Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Apr 6, 2022

@elfosardo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfosardo
Copy link
Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2022
@elfosardo
Copy link
Author

/cc @dtantsur

@openshift-ci openshift-ci bot requested a review from dtantsur April 7, 2022 09:08
joepvd pushed a commit to joepvd/ironic-image that referenced this pull request Apr 11, 2022
@metal3-io-bot
Merge pull request openshift#262 from MaXinjian/space
3d71300 
Add space before ']'
@elfosardo
Copy link
Author

/hold
overridden by #267

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2022
@elfosardo elfosardo closed this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@iurygregory iurygregory Awaiting requested review from iurygregory

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@elfosardo