Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2082103: Enable vMedia provisioning of Nokia servers #274

Merged

Conversation

rhjanders
Copy link

This commit brings the upstream OpenStack/Sushy fixes required
for virtual media based provisioning of Nokia servers into
OpenShift:

https://review.opendev.org/c/openstack/sushy/+/839843
https://review.opendev.org/c/openstack/sushy/+/839844
https://review.opendev.org/c/openstack/sushy/+/839845

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 12, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 12, 2022

@rhjanders: This pull request references Bugzilla bug 2082103, which is invalid:

  • expected dependent Bugzilla bug 2059567 to target a release in 4.10.0, 4.10.z, but it targets "4.11.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2082103: Enable vMedia provisioning of Nokia servers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from elfosardo and hardys May 12, 2022 13:02
@rhjanders
Copy link
Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 12, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 12, 2022

@rhjanders: This pull request references Bugzilla bug 2082103, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2061600 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2061600 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhjanders
Copy link
Author

tagged package for prevalidation ( ironic-tag-builds ocp-4.9 prevalidation python-sushy-3.12.1-0.20220512112437.2b2417e.el8
)

@iurygregory iurygregory added approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels May 12, 2022
main-packages-list.txt Outdated Show resolved Hide resolved
@iurygregory iurygregory removed approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels May 12, 2022
main-packages-list.txt Outdated Show resolved Hide resolved
@elfosardo
Copy link

/hold
need to fix the version

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2022
@dtantsur
Copy link
Member

/hold cancel
/approve
/label backport-risk-assessed

I've fixed the issue to save the time.

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 12, 2022
@dtantsur dtantsur requested a review from elfosardo May 12, 2022 16:03
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2022
@iurygregory
Copy link

/test images
/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@rhjanders
Copy link
Author

/test images

@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@openshift-ci
Copy link

openshift-ci bot commented May 13, 2022

@rhjanders: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfosardo
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, elfosardo, rhjanders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lshilin-r
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 16, 2022
@openshift-merge-robot openshift-merge-robot merged commit 5bdc20f into openshift:release-4.9 May 16, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 16, 2022

@rhjanders: Bugzilla bug 2082103 is in an unrecognized state (VERIFIED) and will not be moved to the MODIFIED state.

In response to this:

Bug 2082103: Enable vMedia provisioning of Nokia servers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/ironic-image that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants