Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2088319: Backport weak eTag handling fix to OpenShift 4.9 #277

Merged
merged 1 commit into from May 24, 2022
Merged

Bug 2088319: Backport weak eTag handling fix to OpenShift 4.9 #277

merged 1 commit into from May 24, 2022

Conversation

rhjanders
Copy link

This commit backports an upstream change in OpenStack/Sushy which
resolves BZ2088319 in OpenShift 4.9:

https://review.opendev.org/c/openstack/sushy/+/842461

@rhjanders
Bug 2088319: Backport weak eTag handling fix to OpenShift 4.9
695bef7 
This commit backports an upstream change in OpenStack/Sushy which
resolves BZ2088319 in OpenShift 4.9:

https://review.opendev.org/c/openstack/sushy/+/842461
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 21, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 21, 2022

@rhjanders: This pull request references Bugzilla bug 2088319, which is invalid:

  • expected dependent Bugzilla bug 2088716 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2088319: Backport weak eTag handling fix to OpenShift 4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dtantsur and elfosardo May 21, 2022 03:28
@rhjanders
Copy link
Author

Package is tagged for prevalidation:

$ ironic-tag-builds ocp-4.9 prevalidation python-sushy-3.12.2-0.20220520212108.9baa774.el8
/usr/lib/python3.10/site-packages/koji/util.py:66: DeprecationWarning: krb_login is deprecated, use gssapi_login instead
warnings.warn(message, DeprecationWarning)
Validating sources...
Tagging builds...
Tagging python-sushy-3.12.2-0.20220520212108.9baa774.el8 in rhaos-4.9-rhel-8-ironic-prevalidation
Watching tasks (this may be safely interrupted)...
45460126 tagBuild (noarch): free
45460126 tagBuild (noarch): free -> closed
0 free 0 open 1 done 0 failed

45460126 tagBuild (noarch) completed successfully
Done!

Leaving it over the weekend to sync.

@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-prevalidation

@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

1 similar comment
@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-prevalidation

@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-prevalidation

@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-prevalidation
/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

1 similar comment
@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-prevalidation
/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@iurygregory
Copy link

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation
/test prevalidation-e2e-metal-ipi-prevalidation

@iurygregory iurygregory added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 23, 2022
@iurygregory
Copy link

The new version contains the patch necessary to handle eTag, adding the backport-risk-assessed label

@rhjanders
Copy link
Author

/test prevalidation-e2e-metal-ipi-prevalidation

@openshift-ci
Copy link

openshift-ci bot commented May 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, iurygregory, rhjanders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2022
@rhjanders
Copy link
Author

Tagged package for production:
$ ironic-tag-builds ocp-4.8 production python-sushy-3.7.5-0.20220520231118.041c8ee.el8
/usr/lib/python3.10/site-packages/koji/util.py:66: DeprecationWarning: krb_login is deprecated, use gssapi_login instead
warnings.warn(message, DeprecationWarning)
Validating sources...
Tagging builds...
Tagging python-sushy-3.7.5-0.20220520231118.041c8ee.el8 in rhaos-4.8-rhel-8-candidate
Watching tasks (this may be safely interrupted)...
45492847 tagBuild (noarch): free
45492847 tagBuild (noarch): free -> closed
0 free 0 open 1 done 0 failed

45492847 tagBuild (noarch) completed successfully
Done!
[janders@carbon ironic-image]$

@rhjanders
Copy link
Author

/test images

@openshift-ci
Copy link

openshift-ci bot commented May 23, 2022

@rhjanders: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lshilin-r
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 24, 2022
@dtantsur
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2022
@rhjanders
Copy link
Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 24, 2022

@rhjanders: This pull request references Bugzilla bug 2088319, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2088716 is in the state CLOSED (CURRENTRELEASE), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2088716 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 8a0cb17 into openshift:release-4.9 May 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 24, 2022

@rhjanders: All pull requests linked via external trackers have merged:

Bugzilla bug 2088319 has been moved to the MODIFIED state.

In response to this:

Bug 2088319: Backport weak eTag handling fix to OpenShift 4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/ironic-image that referenced this pull request Oct 25, 2022
@metal3-io-bot
Merge pull request openshift#277 from Nordix/fix-inspector-endpoint-nam
865944b 
Update the inspector endpoint to port 5049 when using the reverse proxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iurygregory iurygregory iurygregory approved these changes

@elfosardo elfosardo elfosardo approved these changes

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees

@dtantsur dtantsur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rhjanders @iurygregory @lshilin-r @dtantsur @elfosardo @openshift-merge-robot