Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add yum.conf options for smaller image #29

Closed
wants to merge 1 commit into from

Conversation

yazug
Copy link

@yazug yazug commented Nov 14, 2019

  • keepcache=0 instructs yum/dnf to not keep the cache at all
  • install_weak_deps on rhel 8 ends up pulling in unnecessary X11 related bits

- keepcache=0 instructs yum/dnf to not keep the cache at all
- install_weak_deps on rhel 8 ends up pulling in X11 related bits
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 14, 2019
@openshift-ci-robot
Copy link

Hi @yazug. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 14, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yazug
To complete the pull request process, please assign dhellmann
You can assign the PR to them by writing /assign @dhellmann in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elfosardo
Copy link

let's hold on to this until the CI works again
also with the change to dnf from yum #30 , the default for keepcache is False, so no need to add the option
we might want to consider it though for the original image in metal3-io, at least until we use centos 7 and yum

@dtantsur
Copy link
Member

dtantsur commented Jan 9, 2020

With metal3-io#100 approved, I think this should go to the upstream image first.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2020
@openshift-ci-robot
Copy link

@yazug: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yum install -y openstack-ironic-api openstack-ironic-conductor crudini \
RUN echo "keepcache=0" >> /etc/yum.conf && \
yum update -y && \
yum install -y --setopts=install_weak_deps=False \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's setopt, not setopts.

@openshift-ci-robot
Copy link

@yazug: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi 0cfe357 link /test e2e-metal-ipi

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stbenjam
Copy link
Member

This looks like it might be useful, any chance to revisit this? Needs a rebase

@elfosardo
Copy link

this is obsolete as we use dnf now, the default for keepcache is False, so I don't think we need it anymore

@stbenjam
Copy link
Member

/close

@openshift-ci-robot
Copy link

@stbenjam: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member

Feel free to rebase and reopen if it makes sense for dnf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants