New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug OCPBUGS-4305: Remove RDO distribution configuration (finally fixes #46) #326
Bug OCPBUGS-4305: Remove RDO distribution configuration (finally fixes #46) #326
Conversation
It forces using /var/log/ironic/ironic.log, which is not necessary in containers and also grows indefinitely since log rotation is not enabled. (cherry picked from commit 8621a3b)
/cherrypick release-4.12 |
@rhjanders: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: rhjanders The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ci/prow/e2e-metal-ipi-bm failed. From a quick look at CI logs the problem seems in the k8s/ocp application layer - it is very unlikely removing log files (which this PR does) would cause that. Will rerun the job. /test e2e-metal-ipi-bm |
/cc hroyrh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
/lgtm
@rhjanders: This pull request references Jira Issue OCPBUGS-4305, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rhjanders: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@rhjanders: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-4305 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rhjanders: new pull request created: #327 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Use centos stream 9 as base image
It forces using /var/log/ironic/ironic.log, which is not necessary in containers and also grows indefinitely since log rotation is not enabled.
(cherry picked from commit 8621a3b)