Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug OCPBUGS-4305: Remove RDO distribution configuration (finally fixes #46) #326

Merged

Conversation

rhjanders
Copy link

It forces using /var/log/ironic/ironic.log, which is not necessary in containers and also grows indefinitely since log rotation is not enabled.

(cherry picked from commit 8621a3b)

It forces using /var/log/ironic/ironic.log, which is not necessary in
containers and also grows indefinitely since log rotation is not enabled.

(cherry picked from commit 8621a3b)
@rhjanders
Copy link
Author

/cherrypick release-4.12

@openshift-cherrypick-robot

@rhjanders: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iurygregory iurygregory added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: rhjanders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhjanders
Copy link
Author

ci/prow/e2e-metal-ipi-bm failed. From a quick look at CI logs the problem seems in the k8s/ocp application layer - it is very unlikely removing log files (which this PR does) would cause that. Will rerun the job.

/test e2e-metal-ipi-bm

@rhjanders
Copy link
Author

/cc hroyrh

@openshift-ci openshift-ci bot requested a review from hroyrh November 30, 2022 07:14
Copy link

@hroyrh hroyrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2022
@rhjanders rhjanders changed the title Remove RDO distribution configuration (finally fixes #46) Bug OCPBUGS-4305: Remove RDO distribution configuration (finally fixes #46) Nov 30, 2022
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 30, 2022
@openshift-ci-robot
Copy link

@rhjanders: This pull request references Jira Issue OCPBUGS-4305, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @pamoedom

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

It forces using /var/log/ironic/ironic.log, which is not necessary in containers and also grows indefinitely since log rotation is not enabled.

(cherry picked from commit 8621a3b)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from pamoedom November 30, 2022 10:36
@openshift-ci
Copy link

openshift-ci bot commented Nov 30, 2022

@rhjanders: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit acd0274 into openshift:master Nov 30, 2022
@openshift-ci-robot
Copy link

@rhjanders: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4305 has been moved to the MODIFIED state.

In response to this:

It forces using /var/log/ironic/ironic.log, which is not necessary in containers and also grows indefinitely since log rotation is not enabled.

(cherry picked from commit 8621a3b)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@rhjanders: new pull request created: #327

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhjanders rhjanders deleted the no-dist-conf-ocp-master branch November 30, 2022 12:41
zhouhao3 pushed a commit to zhouhao3/ironic-image that referenced this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants