Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-10343: allow inspector to also be proxied #355

Merged
merged 1 commit into from Apr 12, 2023
Merged

OCPBUGS-10343: allow inspector to also be proxied #355

merged 1 commit into from Apr 12, 2023

Conversation

dtantsur
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 30, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2023
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 30, 2023
@openshift-ci-robot
Copy link

@dtantsur: This pull request references Jira Issue OCPBUGS-10343, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 30, 2023
@openshift-ci-robot
Copy link

@dtantsur: This pull request references Jira Issue OCPBUGS-10343, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jhajyahy@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Mar 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2023
@dtantsur dtantsur mentioned this pull request Mar 30, 2023
Merged
@dtantsur
Copy link
Member Author

/retest

@dtantsur dtantsur changed the title WIP: OCPBUGS-10343: allow inspector to also be proxied OCPBUGS-10343: allow inspector to also be proxied Mar 31, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2023
@dtantsur
Copy link
Member Author

dtantsur commented Apr 3, 2023

/test e2e-metal-ipi-bm

@elfosardo
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 41750f9 and 2 for PR HEAD 753e7ed in total

@dtantsur
Copy link
Member Author

dtantsur commented Apr 3, 2023

/test e2e-metal-ipi-bm

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e98d4c1 and 1 for PR HEAD 753e7ed in total

@dtantsur
Copy link
Member Author

dtantsur commented Apr 4, 2023

/test e2e-metal-ipi-bm

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 41de72c and 0 for PR HEAD 753e7ed in total

@openshift-ci-robot
Copy link

/hold

Revision 753e7ed was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2023
@dtantsur
Copy link
Member Author

/hold cancel
/test e2e-metal-ipi-bm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 12, 2023

@dtantsur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 78226b6 into openshift:master Apr 12, 2023
6 checks passed
@openshift-ci-robot
Copy link

@dtantsur: Jira Issue OCPBUGS-10343: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-10343 has not been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur dtantsur deleted the OCPBUGS-10343 branch April 12, 2023 15:24
@dtantsur
Copy link
Member Author

/cherry-pick release-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 19, 2023
Merged
@openshift-cherrypick-robot
Copy link

@dtantsur: new pull request created: #361

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@carbonin
Copy link
Member

/cherry-pick release-4.12

@openshift-cherrypick-robot
Copy link

@carbonin: new pull request created: #384

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@elfosardo elfosardo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dtantsur @openshift-ci-robot @elfosardo @openshift-cherrypick-robot @carbonin @openshift-merge-robot